-
Notifications
You must be signed in to change notification settings - Fork 22
Split artifact uploads into hostapp and testing artifacts #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51fac7e
to
9e15137
Compare
9e15137
to
402542e
Compare
402542e
to
c8293d2
Compare
This environment variable provides a structured path for deploying artifacts that includes the device slug and OS version, which will be used to organize S3 uploads and downloads. Change-type: patch Signed-off-by: Kyle Harding <kyle@balena.io>
This marks a potential future optimization to move the OS contract build step closer to where it's actually used. Signed-off-by: Kyle Harding <kyle@balena.io>
- Move Docker Hub login earlier in workflow to be available for subsequent steps - Update artifact preparation to use S3_DEPLOY_PATH and disable compression - Add deflate file preparation step for S3/webresource deployment - Update encryption to work with individual files instead of tarball Change-type: minor Signed-off-by: Kyle Harding <kyle@balena.io>
- Replace single 'Upload artifacts' with separate uploads for hostapp and testing - Hostapp artifacts include deflate files, manifests, and metadata for S3/webresource deployment - Testing artifacts include images and docker containers needed by Leviathan test suites - Use specific file patterns instead of tarball for better separation of concerns Change-type: minor Signed-off-by: Kyle Harding <kyle@balena.io>
- Update hostapp-deploy, s3-deploy, ami-deploy, and leviathan jobs to use new hostapp/testing artifacts - Replace tarball-based artifact handling with individual file decryption and decompression - Update artifact download paths and decryption logic across all deployment jobs - Add validation for Docker image loading and improve error handling - Clean up environment variable assignments and remove duplicate Docker Hub login steps Change-type: minor Signed-off-by: Kyle Harding <kyle@balena.io>
We haven't supported a deploy type of docker-image for a few years now so we can remove these conditions. Change-type: patch Signed-off-by: Kyle Harding <kyle@balena.io>
Signed-off-by: Kyle Harding <kyle@balena.io>
This makes it easier to see what we are encrypting vs what we are uploading as artifacts. Signed-off-by: Kyle Harding <kyle@balena.io>
6f31fb6
to
2f878b6
Compare
rcooke-warwick
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve the download time for each, and allow
reduction of required hostapp files without breaking tests.
Moving the creation of deflate files to the build job enables us to upload S3 artifacts in both the deploy-S3 and the deploy-hostapp steps (as webresources).
See: https://balena.fibery.io/Work/Improvement/Prepare-deflate-files-before-hostapp-deploy-2913