Windows compatibility patch

.github/workflows/test.yml

@@ -26,14 +26,37 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install tox black
+          pip install -r requirements.txt
 
       - name: Run Tox
         run: tox
 
       - name: Run linter
         run: black --check .
 
+  # On windows we want to test only latest python version.
+  # Everything else will be tested against Linux
+  test_on_windows:
+    runs-on: windows-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v4
+        with:
+          python-version: 3.11
+          update-environment: false
+
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r requirements.txt
+
+      - name: Run tests
+        run: pytest
+
   test_python_2:
     runs-on: ubuntu-latest
 

Dockerfile

@@ -4,7 +4,8 @@ WORKDIR /sdk
 COPY ./requirements.txt /sdk
 
 RUN pip install --upgrade pip \
-    && pip install pytest -r requirements.txt
+    && pip install  $(grep -ivE "black" requirements.txt) 
+# black is not available in python2.7 container
 
 COPY . /sdk
 ENV PYTHONPATH=/sdk

backtracepython/child.py

@@ -24,10 +24,12 @@ def eprint(*args, **kwargs):
 
 
 def post_json(full_url, obj):
+    payload = json.dumps(obj, ignore_nan=True, bigint_as_string=True)
     if globs.debug_backtrace:
-        eprint(full_url)
-        eprint(json.dumps(obj, indent=2, ignore_nan=True))
-    payload = json.dumps(obj, ignore_nan=True).encode("utf-8")
+        data = "Submitting a payload to {},\n {}\n".format(full_url, payload)
+        eprint(data)
+
+    payload = payload.encode("utf-8")
     headers = {
         "Content-Type": "application/json",
         "Content-Length": len(payload),

example/__init__.py

@@ -1,37 +0,0 @@
-import os
-
-import backtracepython as backtrace
-
-
-def open_file(name):
-    open(name).read()
-
-
-def main():
-    backtrace.initialize(
-        endpoint=os.getenv(
-            "BACKTRACE_SUBMISSION_URL",
-            '"https://submit.backtrace.io/your-universe/token/json"',
-        ),
-        attributes={
-            "application": "example-app",
-            "application.version": "1.0.0",
-            "version": "1.0.0",
-        },
-    )
-
-    # send an exception from the try/catch block
-    try:
-        open_file("not existing file")
-    except:
-        backtrace.send_last_exception()
-
-    # send a message
-    backtrace.send_report("test message")
-
-    # generate and send unhandled exception
-    open_file("not existing file")
-
-
-if __name__ == "__main__":
-    main()

example/example.py

@@ -0,0 +1,37 @@
+import os
+
+import backtracepython as backtrace
+
+
+def open_file(name):
+    open(name).read()
+
+
+def main():
+    backtrace.initialize(
+        endpoint=os.getenv(
+            "BACKTRACE_SUBMISSION_URL",
+            '"https://submit.backtrace.io/your-universe/token/json"',
+        ),
+        attributes={
+            "application": "example-app",
+            "application.version": "1.0.0",
+            "version": "1.0.0",
+        },
+    )
+
+    # send an exception from the try/catch block
+    try:
+        open_file("not existing file")
+    except:
+        backtrace.send_last_exception()
+
+    # send a message
+    backtrace.send_report("test message")
+
+    # generate and send unhandled exception
+    open_file("not existing file")
+
+
+if __name__ == "__main__":
+    main()

pytest.ini

@@ -1,2 +1,3 @@
 [pytest]
 pythonpath = .
+faulthandler_timeout = 5

requirements.txt

@@ -1,2 +1,5 @@
 six
 simplejson==3.19.3
+pytest
+tox
+black

setup.py

@@ -2,11 +2,10 @@
 
 from setuptools import find_packages, setup
 
-import backtracepython
 
 setup(
     name="backtracepython",
-    version=backtracepython.version_string,
+    version="0.3.3",
     description="Backtrace.io error reporting tool for Python",
     author="Backtrace.io",
     author_email="team@backtrace.io",

tests/test_basic_flow.py

@@ -26,7 +26,7 @@ def check_basic_report(obj):
 
     source_code_id = obj["threads"][obj["mainThread"]]["stack"][0]["sourceCode"]
     assert obj["sourceCode"][source_code_id]["path"].endswith(
-        "tests/exe/simple_report.py"
+        os.path.join(tests_dir, "exe", "simple_report.py")
     )
     assert obj["sourceCode"][source_code_id]["text"].endswith("\na = b\n")
 
@@ -49,7 +49,9 @@ def check_multi_file(obj):
 
     fault_stack = obj["threads"][obj["mainThread"]]["stack"]
     source_code_id = fault_stack[-1]["sourceCode"]
-    assert obj["sourceCode"][source_code_id]["path"].endswith("tests/exe/multi_file.py")
+    assert obj["sourceCode"][source_code_id]["path"].endswith(
+        os.path.join(tests_dir, "exe", "multi_file.py")
+    )
     lines = obj["sourceCode"][source_code_id]["text"].split("\n")
     assert lines[fault_stack[-1]["line"] - 1] == "call_a_file(True)"
 
@@ -91,19 +93,11 @@ def log_message(self, format, *args):
     host, port = httpd.server_address
 
     exe_path = os.path.join(exe_dir, exe_name)
-    stdio_action = None if debug_backtrace else subprocess.PIPE
-    child = subprocess.Popen(
-        [sys.executable, exe_path, host, str(port)],
-        stdout=stdio_action,
-        stderr=stdio_action,
-    )
+    child = subprocess.Popen([sys.executable, exe_path, host, str(port)])
 
     httpd.handle_request()
     check_fn(non_local.json_object)
     child.wait()
-    if stdio_action is not None:
-        child.stdout.close()
-        child.stderr.close()
     httpd.server_close()