Windows compatibility patch #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf2711
approved these changes
Sep 10, 2024
Dockerfile
Outdated
Comment on lines
7
to
8
| && pip install $(grep -ivE "black" requirements.txt) | ||
| # black is not available in python2.7 container |
There was a problem hiding this comment.
why not create a separate requirements.txt for Python 2.7?
There was a problem hiding this comment.
or, better yet, use conditionals https://stackoverflow.com/a/35614580
There was a problem hiding this comment.
Changed the approach based on your last suggestion. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This pull request fixes problems I experienced during Windows integration.
Hightlights: