react-native: replace AlternatingFileWriter with WritableStream and ChunkifierSink for breadcrumbs #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf2711
force-pushed
the
bugfix/BT-5147-react-native-breadcrumbs
branch
from
545f249 to
1ad7f87
Compare
konraddysput
approved these changes
Nov 14, 2024
packages/react-native/src/breadcrumbs/FileBreadcrumbsStorage.ts
Outdated
Show resolved
Hide resolved
| public async write(data: W): Promise<void> { | ||
| // If data is empty from the start, forward the write directly to current stream | ||
| if (this.isEmpty(data)) { | ||
| return await this.ensureStreamContext().streamWriter.write(data); |
There was a problem hiding this comment.
do we need to run a write operation at all? Based on the stream writer implementation, we don't need to?
There was a problem hiding this comment.
It's just that any write to this sink should end up in calling write on the underlying stream.
perf2711
force-pushed
the
bugfix/BT-5147-react-native-breadcrumbs
branch
from
0872be8 to
414e2a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
AlternatingFileWriterwithWritableStreamandChunkifierSinkbased onchunkifierfrom Node.As React Native does not have a
WritableStreamsupport by default, a ponyfill is used.