Skip to content

fix: mining fails in Creative Mode #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

fix: mining fails in Creative Mode #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions azalea-client/src/plugins/mining.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,13 +255,25 @@ fn handle_mining_queued(
// is outside of the worldborder

if game_mode.current == GameMode::Creative {
// In creative mode, first send START_DESTROY_BLOCK packet then immediately
// finish mining
commands.trigger(SendPacketEvent::new(
entity,
ServerboundPlayerAction {
action: s_player_action::Action::StartDestroyBlock,
pos: mining_queued.position,
direction: mining_queued.direction,
seq: sequence_number.start_predicting(),
},
));
commands.trigger_targets(
FinishMiningBlockEvent {
position: mining_queued.position,
},
entity,
);
**mine_delay = 5;
commands.trigger(SwingArmEvent { entity });
} else if mining.is_none()
|| !is_same_mining_target(
mining_queued.position,
Expand Down Expand Up @@ -579,12 +591,6 @@ pub fn continue_mining_block(
if game_mode.current == GameMode::Creative {
// TODO: worldborder check
**mine_delay = 5;
commands.trigger_targets(
FinishMiningBlockEvent {
position: mining.pos,
},
entity,
);
commands.trigger(SendPacketEvent::new(
entity,
ServerboundPlayerAction {
Expand All @@ -594,6 +600,12 @@ pub fn continue_mining_block(
seq: prediction_handler.start_predicting(),
},
));
commands.trigger_targets(
FinishMiningBlockEvent {
position: mining.pos,
},
entity,
);
commands.trigger(SwingArmEvent { entity });
} else if mining.force
|| is_same_mining_target(
Expand Down
Loading