Skip to content

Conversation

@eihqnh
Copy link
Contributor

@eihqnh eihqnh commented Aug 13, 2025

bot.mine() is not working in Creative mode.(spigot&vanilla)
works on vanilla (open to LAN) & paper (GrimAC CE)

Copy link
Collaborator

@mat-1 mat-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The two additional triggers look good to me, but I think the code you removed (the **mine_delay = 5 and the stuff in continue_mining_block) should be kept since those are what handle the case where left-click is held down (since vanilla adds some extra delays when you do that).

@eihqnh
Copy link
Contributor Author

eihqnh commented Aug 14, 2025

Thanks for the PR!

The two additional triggers look good to me, but I think the code you removed (the **mine_delay = 5 and the stuff in continue_mining_block) should be kept since those are what handle the case where left-click is held down (since vanilla adds some extra delays when you do that).

got it, thank you very much

Additional changes:
The packet sending order for creative mode in the continue_mining_block function seemed reversed, which affected bot.left_click_mine. It has been fixed and tested.

Thank you for your patient explanation and guidance :3

Copy link
Collaborator

@mat-1 mat-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mat-1 mat-1 merged commit 6695132 into azalea-rs:main Aug 15, 2025
1 check passed
@eihqnh eihqnh deleted the fix-mining branch August 15, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants