Skip to content

Auto Monitor follow up changes #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

Auto Monitor follow up changes #311

merged 3 commits into from
May 22, 2025

Conversation

the-mann
Copy link
Contributor

Description of changes

  1. remove shouldOverrideMultiInstrumentation: Introduce AutoMonitor for simpler enablement of Application Signals #297 (comment)
  2. Create SharedIndexInformer for workloads to avoid listing them during a service update: Introduce AutoMonitor for simpler enablement of Application Signals #297 (comment)
  3. Use patching instead of updating for deployment modifications during service updates (restartPods: true): Introduce AutoMonitor for simpler enablement of Application Signals #297 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@the-mann
Copy link
Contributor Author

https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/15049225677

@the-mann the-mann mentioned this pull request May 15, 2025
Closed
lisguo
lisguo reviewed May 21, 2025
View reviewed changes
@the-mann
Copy link
Contributor Author

https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/15171898076

movence
movence reviewed May 21, 2025
View reviewed changes
@the-mann the-mann merged commit 655ac06 into hsookim/appsignals-1-step May 22, 2025
36 of 38 checks passed
@the-mann the-mann deleted the mpmann/auto-monitor-follow-up branch May 22, 2025 12:57
@the-mann the-mann restored the mpmann/auto-monitor-follow-up branch May 23, 2025 15:27
@the-mann the-mann deleted the mpmann/auto-monitor-follow-up branch May 23, 2025 15:27
the-mann added a commit that referenced this pull request May 23, 2025
@the-mann
Auto Monitor follow up changes (#311)
731d12a 
* Implement patching and workload informers

* Update EnableMultiInstrumentationSupport and SkipMultiInstrumentationContainerValidation feature flags to be enabled by default

* incorporate feedback
@the-mann the-mann mentioned this pull request May 23, 2025
Merged
the-mann added a commit that referenced this pull request May 23, 2025
@the-mann
Auto Monitor follow up changes (#315)
7ef7265 
(Originally reviewed in "Auto Monitor follow up changes (#311)")

* Implement patching and workload informers

* Update EnableMultiInstrumentationSupport and SkipMultiInstrumentationContainerValidation feature flags to be enabled by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@movence movence movence approved these changes

@lisguo lisguo lisguo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-mann @movence @lisguo