AppSignals AutoMonitor follow up + integration testing #306

movence · 2025-05-05T14:27:48Z

Description of changes:

Merge Auto Monitor follow up changes #311 changes into main
Add integration tests for AutoMonitor
Speed up integration test runs by caching docker image between each integration test run

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…plate ObjectMeta

…h AutoMonitor and AnnotationMutators, check if safe to mutate before applying custom selector, run opt out tests for each type of workload, test opt out by disabling monitorallservices

CustomSelectors should obey autoRestart, autoAnnotateAutoInstrumentation shouldn't. Rename MonitorInterface to InstrumentationAnnotator. Add docs.

…estartPods

…ntation container validation by default. This is required for automonitor to work, because it tries to apply all init containers to each selected pod.

… update pod templates in workloads.

…el custom selector should not update pod template

…art namespace for autoAnnotateAutoInstrumentation.

…on test

the-mann · 2025-05-15T15:38:21Z

will fail/be flakey until #311 is merged in

* Implement patching and workload informers * Update EnableMultiInstrumentationSupport and SkipMultiInstrumentationContainerValidation feature flags to be enabled by default * incorporate feedback

the-mann · 2025-05-22T13:06:54Z

main.go

reviewed in #311

the-mann · 2025-05-22T13:07:00Z

pkg/featuregate/featuregate.go

reviewed in #311

the-mann · 2025-05-22T13:07:04Z

pkg/instrumentation/auto/monitor.go

reviewed in #311

the-mann · 2025-05-22T13:07:10Z

pkg/instrumentation/auto/monitor_test.go

reviewed in #311

the-mann · 2025-05-22T13:07:14Z

pkg/instrumentation/auto/util.go

reviewed in #311

the-mann · 2025-05-22T13:07:19Z

pkg/instrumentation/auto/util_test.go

reviewed in #311

the-mann · 2025-05-22T13:07:23Z

pkg/instrumentation/golang_test.go

reviewed in #311

the-mann · 2025-05-22T13:07:27Z

pkg/instrumentation/podmutator.go

reviewed in #311

the-mann · 2025-05-22T13:07:32Z

pkg/instrumentation/podmutator_test.go

reviewed in #311

the-mann added 30 commits March 10, 2025 10:06

almost all passing

7c8774d

passing

95b11c2

check pod template labels instead of workload labels

2a6d9df

Provide Monitor functions (except Mutate) workload instead of pod tem…

b50163c

…plate ObjectMeta

big progress

3ce94cf

more progress

97ee02b

works

24c29cd

blah

b2d6c1c

blah

c70f7f8

fix logging, add more testing

e47e85a

remove unnecessary HasSynced

6ab7980

Handle service deletion, service update. test service deletion

82750e1

Improve backwards compatability, make MutateAndPatchAll work with bot…

a886b9a

…h AutoMonitor and AnnotationMutators, check if safe to mutate before applying custom selector, run opt out tests for each type of workload, test opt out by disabling monitorallservices

Maintain legacy autoAnnotateAutoInstrumentation behavior.

9d6b4a7

CustomSelectors should obey autoRestart, autoAnnotateAutoInstrumentation shouldn't. Rename MonitorInterface to InstrumentationAnnotator. Add docs.

Clean up

1216808

undo dockerfile update

b5a0e96

Fix integration tests

e1cf759

Rename auto_monitor*.go files to monitor*.go, rename AutoRestart to R…

33df3e8

…estartPods

Enable multi instrumentation feature flag, enable skip multi instrume…

734966f

…ntation container validation by default. This is required for automonitor to work, because it tries to apply all init containers to each selected pod.

come up with actual commit message

ed696e5

Update tests to expect namespace in exclude and customSelector to…

319e18a

… update pod templates in workloads.

add transformer, warning function

42f6e23

fix integration tests to work with new exclude syntax

d35ed59

namespace-level exclude should update pod template, but namespace-lev…

fbafe30

…el custom selector should not update pod template

Use correct autoAnnotationConfigStr to create Instrumentation Annotator

d65c9f0

Restart namespace for AutoMonitor based on restartPods, always rest…

eecdc14

…art namespace for autoAnnotateAutoInstrumentation.

omit languages, exclude, and customselector when empty

185ff81

add more integ tests for AutoMonitor

c28093a

fix permutation 9 (don't use kube-system)

707856b

improve comments

a702b6a

the-mann added 15 commits May 13, 2025 15:58

fix TestServiceThenDeployment

988c1eb

fix 21

4e39db8

improve logging

1d0ef86

fix test 21

52c6aa7

fix test 21

e288425

fix logging

d8b8e46

Reduce throttling by adding SharedIndexInformers for workloads

6a94cde

use patching

a940c37

use patching

5f0693b

use patching

8571943

Add TestDeploymentThenServiceRestartPodsEnabledSameManifest integrati…

bc2a0b3

…on test

remove sleeps to speed up tests

8b5fbfc

revert remove sleep to speed up tests

5d3ae8f

Move informer initialization logic to util.go

52afaf2

move follow up changes to mpmann/auto-monitor-follow-up branch

ca244fc

Auto Monitor follow up changes (#311)

655ac06

* Implement patching and workload informers * Update EnableMultiInstrumentationSupport and SkipMultiInstrumentationContainerValidation feature flags to be enabled by default * incorporate feedback