Lambda Support Refactor + Enhance Unit Test Coverage for AWS Resources #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in queue name case
yiyuan-he
changed the title
yiyuan-he
commented
Jun 9, 2025
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Show resolved
Hide resolved
thpierce
reviewed
Jun 9, 2025
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/aws-metric-attribute-generator.test.ts
Show resolved
Hide resolved
jj22ee
reviewed
Jun 12, 2025
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/aws-metric-attribute-generator.test.ts
Show resolved
Hide resolved
jj22ee
approved these changes
Jun 13, 2025
thpierce
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Refactors changes made for AWS Lambda support to make the more maintainable and easier to reason about.
These changes also improve our test coverage to assert these new Lambda behaviors as well as existing behaviors for other AWS Resources (S3, DDB, SNS, etc.).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.