Lambda Support Refactor + Enhance Unit Test Coverage for AWS Resources #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
reviewed
Jun 12, 2025
src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AwsMetricAttributeGenerator.cs
Outdated
Show resolved
Hide resolved
yiyuan-he
reviewed
Jun 12, 2025
test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AwsMetricAttributesGeneratorTest.cs
Show resolved
Hide resolved
yiyuan-he
reviewed
Jun 12, 2025
test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AwsMetricAttributesGeneratorTest.cs
Outdated
Show resolved
Hide resolved
yiyuan-he
reviewed
Jun 12, 2025
test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AwsMetricAttributesGeneratorTest.cs
Outdated
Show resolved
Hide resolved
yiyuan-he
approved these changes
Jun 18, 2025
thpierce
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Refactors changes for AWS Lambda support to make them more maintainable and easy to reason about. Also improves test coverage for Lambda behavior as well as remote resources (Service names, CFN Id, etc.)
Matches refactoring changes made in other ADOT languages: see Python and JS
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.