Skip to content

Support Nested Wildcard Lists #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -563,8 +563,14 @@ void addDependsOnGeneric(Set<UType> set) {
}

void builderGetDependency(Append writer, String builderName) {
writer.append(builderName).append(".").append(utilType.getMethod(nullable, isBeanMap));
if (!genericType.isGeneric() || genericType.param0().kind() == TypeKind.WILDCARD) {
final boolean wildcard = isWildcard();
final var wildParam = wildcard ? String.format("<%s>", genericType.shortWithoutAnnotations()) : "";
writer
.append(builderName)
.append(".")
.append(wildParam)
.append(utilType.getMethod(nullable, isBeanMap));
if (!genericType.isGeneric() || wildcard) {
writer.append(Util.shortName(genericType.mainType())).append(".class");
} else {
writer.append("TYPE_").append(Util.shortName(genericType).replace(".", "_"));
Expand All @@ -585,6 +591,11 @@ void builderGetDependency(Append writer, String builderName) {
writer.append(")");
}

private boolean isWildcard() {
return genericType.isGeneric()
&& genericType.componentTypes().stream().allMatch(g -> g.kind() == TypeKind.WILDCARD);
}

String simpleName() {
return simpleName;
}
Expand All @@ -602,7 +613,7 @@ boolean isGenericParam() {
}

Dependency dependsOn() {
return new Dependency(paramType, named, utilType.isCollection());
return new Dependency(isWildcard() ? genericType.mainType() : paramType, named, utilType.isCollection());
}

void addImports(ImportTypeMap importTypes) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,13 +210,17 @@ private void addSuperType(TypeElement element, TypeMirror mirror, boolean proxyB
final String type = Util.unwrapProvider(fullName);

if (proxyBean || isPublic(element)) {
final var genericType = !Objects.equals(fullName, type) ? UType.parse(mirror).param0() : UType.parse(mirror);
UType uType = UType.parse(mirror);
final var genericType = !Objects.equals(fullName, type) ? uType.param0() : uType;
// check if any unknown generic types are in the parameters (T,T2, etc.)
final var knownType = genericType.componentTypes().stream()
.flatMap(g -> Stream.concat(Stream.of(g), g.componentTypes().stream()))
.noneMatch(g -> g.kind() == TypeKind.TYPEVAR);

extendsTypes.add(knownType ? Util.unwrapProvider(mirror) : genericType);
if (uType.isGeneric()) {
extendsTypes.add(UType.parse(types().erasure(Util.stripProvider(mirror))));
}
extendsInjection.read(element);
}

Expand Down Expand Up @@ -257,6 +261,9 @@ private void readInterfacesOf(TypeMirror anInterface) {
}
}
interfaceTypes.add(rawUType);
if (rawUType.isGeneric()) {
interfaceTypes.add(UType.parse(types().erasure(Util.stripProvider(anInterface))));
}
for (final TypeMirror supertype : types().directSupertypes(anInterface)) {
readInterfacesOf(supertype);
}
Expand Down
18 changes: 11 additions & 7 deletions inject-generator/src/main/java/io/avaje/inject/generator/Util.java
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ private static boolean importJavaLangSubpackage(String type) {

static String classOfMethod(String method) {
final int pos = method.lastIndexOf('.');
return (pos == -1) ? "" : method.substring(0, pos);
return pos == -1 ? "" : method.substring(0, pos);
}

static String shortMethod(String method) {
Expand Down Expand Up @@ -92,7 +92,7 @@ static String nestedPackageOf(String cls) {
return "";
}
pos = cls.lastIndexOf('.', pos - 1);
return (pos == -1) ? "" : cls.substring(0, pos);
return pos == -1 ? "" : cls.substring(0, pos);
}

static String unwrapProvider(String maybeProvider) {
Expand All @@ -104,11 +104,7 @@ static String unwrapProvider(String maybeProvider) {
}

static UType unwrapProvider(TypeMirror maybeProvider) {
if (isProvider(maybeProvider.toString())) {
return UType.parse(maybeProvider).param0();
} else {
return UType.parse(maybeProvider);
}
return UType.parse(stripProvider(maybeProvider));
}

static UType unwrapProvider(UType maybeProvider) {
Expand All @@ -119,6 +115,14 @@ static UType unwrapProvider(UType maybeProvider) {
}
}

static TypeMirror stripProvider(TypeMirror maybeProvider) {
if (isProvider(maybeProvider.toString())) {
return ((DeclaredType) maybeProvider).getTypeArguments().get(0);
} else {
return maybeProvider;
}
}

static String initLower(String name) {
final StringBuilder sb = new StringBuilder(name.length());
boolean upper = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import org.example.coffee.core.DuperPump;
import org.example.coffee.generic.HazRepo;
import org.example.coffee.generic.HazRepo$DI;
import org.example.coffee.generic.Repository;
import org.example.coffee.list.BSomei;
import org.example.coffee.list.Somei;
import org.example.coffee.provider.AProv;
Expand Down Expand Up @@ -115,7 +116,7 @@ void beanScope_all_includesGenericInterfaces() {
.findFirst().orElse(null);

assertThat(hazRepo.keys())
.containsExactly(name(HazRepo.class), name(HazRepo$DI.TYPE_RepositoryHazLong));
.containsExactly(name(HazRepo.class), name(HazRepo$DI.TYPE_RepositoryHazLong), name(Repository.class));
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package org.example.coffee.generic;

import java.util.List;

import org.example.coffee.grind.AMusher;

import jakarta.inject.Singleton;
Expand All @@ -16,18 +18,29 @@ class MultiGenericConsumer {

private final AMusher aMusher;

MultiGenericConsumer(Repository<Haz, Long> hazRepo, AMusher aMusher, SomeGeneric<String> stringProcessor) {
private List<SomeGeneric<?>> list;

MultiGenericConsumer(
Repository<Haz, Long> hazRepo,
AMusher aMusher,
SomeGeneric<String> stringProcessor,
List<SomeGeneric<?>> list) {
this.hazRepo = hazRepo;
this.aMusher = aMusher;
this.stringProcessor = stringProcessor;
this.list = list;
}

String findAndDo(long id) {
final Haz byId = hazRepo.findById(id);
return (byId == null) ? "not found" : "found " + stringProcessor.process("" + byId.id);
return byId == null ? "not found" : "found " + stringProcessor.process("" + byId.id);
}

String mushString() {
return aMusher.toString();
}

List<SomeGeneric<?>> list() {
return list;
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
package org.example.coffee.generic;

import io.avaje.inject.xtra.ApplicationScope;
import static org.assertj.core.api.Assertions.assertThat;

import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;
import io.avaje.inject.xtra.ApplicationScope;

public class MultiGenericConsumerTest {

Expand All @@ -14,6 +15,6 @@ public void find() {

assertThat(bean.findAndDo(34L)).isEqualTo("found 34 stuff");
assertThat(bean.mushString()).isNotNull();
assertThat(bean.list()).isNotEmpty();
}

}