Skip to content

Support Nested Wildcard Lists #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2025
Merged

Support Nested Wildcard Lists #817

merged 4 commits into from
May 9, 2025

Conversation

SentryMan
Copy link
Collaborator

  • fix cases where a list of generic wildcards generates bad code
  • now generic types are registered with their main type as a key

@SentryMan SentryMan added this to the 11.6 milestone May 8, 2025
@SentryMan SentryMan requested a review from rbygrave May 8, 2025 00:52
@SentryMan SentryMan self-assigned this May 8, 2025
@SentryMan SentryMan added bug Something isn't working enhancement New feature or request labels May 8, 2025
@SentryMan SentryMan enabled auto-merge May 8, 2025 00:54
@SentryMan SentryMan disabled auto-merge May 8, 2025 00:54
@SentryMan SentryMan enabled auto-merge (squash) May 8, 2025 00:54
@SentryMan
support nested wildcard lists
8f0dacf 
- fix cases where a list of generic wildcards generates bad code
- now generic types are registered with their main type as a key
rbygrave
rbygrave approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@rbygrave rbygrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note I reverted the autoProvides() change

@SentryMan SentryMan merged commit da83dd1 into avaje:master May 9, 2025
5 checks passed
@SentryMan
Copy link
Collaborator Author

Note I reverted the autoProvides() change

Any particular reason why?

@SentryMan SentryMan deleted the wildcard-list branch May 9, 2025 04:58
@rbygrave
Copy link
Contributor

rbygrave commented May 9, 2025

Any particular reason why?

For MyType<T> we don't actually know what type we can provide, unlike say MyType<OtherType>. If another module needs MyType<Foo> we don't know if this module can provide that dependency or not.

For this reason these types have been excluded from the autoProvides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave rbygrave approved these changes

Assignees

@SentryMan SentryMan

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
11.6
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave