-
Notifications
You must be signed in to change notification settings - Fork 44
feat: add Learning-Based Accel/Brake Map Calibrator #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add Learning-Based Accel/Brake Map Calibrator #231
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
bc8a353
to
5f9af35
Compare
389a945
to
a171e56
Compare
@xmfcx Hi, just for your information, I opened the previous pull request in Autoware Tools, as you suggested. |
@takayuki5168 -san, could you review the autoware_debug_tools/frequent_log_checker.py changes? |
common/autoware_debug_tools/autoware_debug_tools/frequent_log_checker.py
Outdated
Show resolved
Hide resolved
98eb188
to
b5874e2
Compare
08d90f1
to
75791f3
Compare
Spell check issue should be fixed once we merge: |
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
Signed-off-by: Cristian Gariboldi <gariboldicristian@gmail.com>
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
8d03cb8
to
72e4bbb
Compare
I'll test it with AWSIM Labs and report my findings. AWSIM Labs was calibrated with https://github.com/autowarefoundation/autoware_universe/tree/main/vehicle/autoware_accel_brake_map_calibrator before. The calibration results are in https://github.com/autowarefoundation/autoware_launch/blob/main/vehicle/awsim_labs_vehicle_launch/awsim_labs_vehicle_launch/config/raw_vehicle_cmd_converter/raw_vehicle_cmd_converter.param.yaml and it is used while driving. I will also calibrate with your tool to see how it differs. |
Description
This is the PR regarding the learning-based vehicle calibration for longitudinal dynamics already discussed and presented in the discussion thread and in the Planning and Control meeting.
Tests performed
This calibrator has been tested in simulation and real vehicles. We've been using the calibrator for a different range of vehicles in Pix Moving with high accuracy.
Additional materials here:
Pix_Longitudinal_Calibration.pdf
Calibration.pptx
Effects on system behavior
This new calibrator improves the previous one in different aspects:
real data are interpolated with a neural network, which is able to provide a very accurate and smooth map, and can capture the non-linearities of the system;
the whole calibration process is very user-friendly, fast and efficient;
you don't need a huge amount of data for training the neural network, making the data collection process faster;
the learning-based approach can be easily adapted to different kind of scenarios, and not solely on the longitudinal dynamic. In my previous pull request for example, I also included the calibration for steering/parking scenarios, just by adding 1 input to the network;
It can be used with a diverse range of vehicles, with different dynamics, kinematics, engines and transmission systems;
It has been tested in simulation and with real vehicles. We now use it for calibrating our vehicles in Pix Moving.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.