fix(velocity_smoother): prevent access when vector is empty #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitukou1109
requested review from
rej55,
go-sakayori,
mkuri,
satoshi-ota,
TakaHoribe and
a team
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kosuke55
approved these changes
Apr 24, 2025
kosuke55
added
the
run:build-and-test-differential
|
@rej55 @satoshi-ota |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
===========================================
- Coverage 78.75% 24.32% -54.44%
===========================================
Files 11 178 +167
Lines 193 11928 +11735
Branches 73 3544 +3471
===========================================
+ Hits 152 2901 +2749
- Misses 11 8641 +8630
- Partials 30 386 +356
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
kosuke55
force-pushed
the
fix/velocity-smoother-empty-check
branch
from
f03d7f1 to
d4d859e
Compare
go-sakayori
approved these changes
Apr 24, 2025
satoshi-ota
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
velocity_smootherto prevent access to any element in a vector when it's empty.Related links
Internal: https://star4.slack.com/archives/C0575HP7NJG/p1744865921175659?thread_ts=1744862416.400339&cid=C0575HP7NJG
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.