Skip to content

Added section about closing formatting PRs without review #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Added section about closing formatting PRs without review #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions policies/pull-request-review-and-merge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ follows these guidelines.
After successful review, the maintainer(s) will formally approve the pull
request.

While we welcome pull requests for anyone, pull requests that are purely related
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
While we welcome pull requests for anyone, pull requests that are purely related
While we welcome pull requests from anyone, pull requests that are purely related

to code formatting or restructuring without change in functionality (including,
but not limited to, the use of automated tools) may in some cases be closed
without review, since these kinds of changes can cause unecessary conflicts with
other pull requests, or may not line up with the coding style or wishes of the
current maintainer(s). In these cases, it should be made clear to the contributor
that we still value their interest in contributing to the project, but point
them to this policy to explain that we cannot always accept these kinds of
changes.

### Additional Checks

Additional checks will be performed to verify that there are no other issues
Expand Down