Added section about closing formatting PRs without review #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
reviewed
Jun 30, 2025
| @@ -39,6 +39,16 @@ follows these guidelines. | |||
| After successful review, the maintainer(s) will formally approve the pull | |||
| request. | |||
|
|
|||
| While we welcome pull requests for anyone, pull requests that are purely related | |||
There was a problem hiding this comment.
Suggested change
| While we welcome pull requests for anyone, pull requests that are purely related | |
| While we welcome pull requests from anyone, pull requests that are purely related |
|
I think there was also a comment at the meeting that this document should be linked from astropy core dev docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft, to try and address the concept brought up during the coordination meeting that we should be able to close unsolicited formatting/restructuring PRs that don't have a clear benefit. Happy to iterate on the wording!