Skip to content

update installer.sh with improvements from rustup-init.sh #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2025

Conversation

Gankra
Copy link
Collaborator

@Gankra Gankra commented Apr 17, 2025

Includes:

  • Better support for illumos' accursed ksh (now pushes through instead of erroring)
  • Better support for /proc not being mounted (occurs in docker buildx -- now pushes through instead of erroring)
  • Better detection of "oldworld" loongarch (eagerly errors)
  • Handles an issue where macos sysctl spews errors
  • Better detection of 32-bit userland on aarch64

Notably this does not reverse an earlier decision to drop most of the complex wget/curl ciphersuite detection from rustup-init.sh. Doing so would be a much larger and higher risk change, as we do not use the same hosting infra that rustup uses, and the logic for it is like, 200 lines of evil sh scripting.

We probably do want to eventually reverse that decision, just not today. A casualty of this decision is this update doesn't include the retry logic for downloads they have (because passing retry flags requires a ton of feature-detection logic they include).

Fixes #15

@Gankra Gankra added bug Something isn't working enhancement New feature or request labels Apr 17, 2025
@Gankra
Copy link
Collaborator Author

Gankra commented Apr 17, 2025

@Gankra Gankra merged commit 4ca3e12 into main Apr 17, 2025
13 checks passed
@Gankra
Copy link
Collaborator Author

Gankra commented Apr 17, 2025

Additional context: installer.ps1 doesn't come from rustup, to the best of my knowledge it originates whole cloth from apollo graphql's installers, which don't really get much updating. It also has a lot less corner cases to handle.

@Gankra Gankra mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update installer.sh.j2
1 participant