update installer.sh with improvements from rustup-init.sh #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
/proc
not being mounted (occurs indocker buildx
-- now pushes through instead of erroring)Notably this does not reverse an earlier decision to drop most of the complex wget/curl ciphersuite detection from rustup-init.sh. Doing so would be a much larger and higher risk change, as we do not use the same hosting infra that rustup uses, and the logic for it is like, 200 lines of evil sh scripting.
We probably do want to eventually reverse that decision, just not today. A casualty of this decision is this update doesn't include the retry logic for downloads they have (because passing retry flags requires a ton of feature-detection logic they include).
Fixes #15