Avoid snap curl

[konstin]

curl installed with snap is broken (boukendesho/curl-snap#1 (comment)), so we try to avoid it by using wget, and if that fails, we error eagerly.

[konstin]

@Gankra do you think this approach works?

[Gankra]

Oh interesting, I definitely like the idea!

You may also be interested in #26 (comment)

[konstin]

I've manually tested this on local machine with snap and apt, are there any other validations to make sure this works as intended across shells?

[Gankra]

The main cross-shell validation is just that we run shellcheck with ksh as the target env, since it's like, the most barebones unix-standards-following shell. So as long as we only use constructs that should work in ksh, and it runs fine in bash, it tends to work fine everywhere.

[konstin]

I ran shellcheck -s ksh on the generated uv-installer.sh for uv and it only showed an unrelated warning, but no warning for the changed lines.

    RECEIPT="$(echo "$RECEIPT" | sed s/'"CARGO_DIST_BINS"'/"$_bins_js_array"/)"
               ^-- SC2001 (style): See if you can use ${variable//search/replace} instead.

[Gankra]

Great improvement!

[Gankra]

(Also clarification: I meant shellcheck with dash, which is just configured and run as part of the test-suite. I always mix up those two because they're the two "worst" shells we support -- in the case of dash this is intentional, in the case of ksh it's because it belongs in hell.)