Add cacheInterceptor() and autoPersistedQueriesInterceptor() #6455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
commented
Apr 7, 2025
Comment on lines
-126
to
-131
| // Removing existing interceptors added for configuring an [ApolloStore]. | ||
| // If a builder is reused from an existing client using `newBuilder()` and we try to configure a new `store()` on it, we first need to | ||
| // remove the old interceptors. | ||
| val storeInterceptors = interceptors.filterIsInstance<ApolloStoreInterceptor>() | ||
| storeInterceptors.forEach { | ||
| removeInterceptor(it) |
There was a problem hiding this comment.
This is not an issue anymore!
There was a problem hiding this comment.
Maybe the ApolloStoreInterceptor interface can also be deleted, then?
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 423ee57de2d9619f11115d73 |
BoD
reviewed
Apr 8, 2025
| @@ -228,8 +259,8 @@ internal fun <D : Query.Data> ApolloCall<D>.watchInternal(data: D?): Flow<Apollo | |||
|
|
|||
| val ApolloClient.apolloStore: ApolloStore | |||
| get() { | |||
| return interceptors.firstOrNull { it is ApolloCacheInterceptor }?.let { | |||
There was a problem hiding this comment.
I think this no longer works, and should be cacheInterceptor (but then it must be made public)?
There was a problem hiding this comment.
but then it must be made public
I have made it public
martinbonnin
commented
Apr 8, 2025
Comment on lines
117
to
123
| return chain.proceed(request).map { response -> | ||
| response.newBuilder().cacheHeaders(CacheHeaders.Builder().addHeader(ApolloCacheHeaders.DO_NOT_STORE, "").build()).build() | ||
| } | ||
| return chain.proceed( | ||
| request.newBuilder() | ||
| .cacheHeaders( | ||
| CacheHeaders.Builder().addHeader(ApolloCacheHeaders.DO_NOT_STORE, "").build() | ||
| ) | ||
| .build() | ||
| ) |
There was a problem hiding this comment.
Yet another good side effect IMO.
BoD
pushed a commit
that referenced
this pull request
Apr 8, 2025
* Add cacheInterceptor() and autoPersistedQueriesInterceptor() * make cacheInterceptor public * add mention in the changelog * remove obsolete tests * update the test to include patching based on the response * update README (cherry picked from commit 1a9918a)
BoD
added a commit
that referenced
this pull request
Apr 8, 2025
…6456) * Add cacheInterceptor() and autoPersistedQueriesInterceptor() * make cacheInterceptor public * add mention in the changelog * remove obsolete tests * update the test to include patching based on the response * update README (cherry picked from commit 1a9918a) Co-authored-by: Martin Bonnin <martin@mbonnin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See apollographql/apollo-kotlin-normalized-cache#123 (comment)