[SPARK-52704][SQL] Simplify interoperations between SQLConf and file-format options in TextBasedFileFormats #51398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…format options in TextBasedFileFormats
LuciferYang
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
+1, LGTM
This refactoring appears to be safe. thank you @yaooqinn
|
The Docker IT failure is a known issue, Merged to master, thank you @LuciferYang |
There was a problem hiding this comment.
Sorry but I'm not sure why trait FileFormat should have these utility classes directly? IMO, these should be designed as a new trait and TextBasedFileFormats can use them by additional with clause. WDYT, @yaooqinn and @LuciferYang ?
protected def sessionState(sparkSession: SparkSession): SessionState = {
sparkSession.sessionState
}
protected def sqlConf(sparkSession: SparkSession): SQLConf = {
sessionState(sparkSession).conf
}
protected def hadoopConf(
sparkSession: SparkSession,
options: Map[String, String]): Configuration = {
sessionState(sparkSession).newHadoopConfWithOptions(options)
}|
|
||
| protected def sessionState(sparkSession: SparkSession): SessionState = { | ||
| sparkSession.sessionState | ||
| } |
There was a problem hiding this comment.
According to the method body, this method is a kind of utility method which can be a static method also.
|
|
||
| protected def sqlConf(sparkSession: SparkSession): SQLConf = { | ||
| sessionState(sparkSession).conf | ||
| } |
There was a problem hiding this comment.
This is the same. Both sqlConf and sessionState can be a utility method which can be a static method also.
| sparkSession: SparkSession, | ||
| options: Map[String, String]): Configuration = { | ||
| sessionState(sparkSession).newHadoopConfWithOptions(options) | ||
| } |
There was a problem hiding this comment.
ditto. This method has no relation to any underlying objects or trait FileFormat directly. We had better put this outside independently with the above sessionState and sqlConf methods
|
cc @peter-toth |
|
Thank you @dongjoon-hyun for the advices, I will make a followup |
|
Thank you, @yaooqinn |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 9, 2025
…FileFormat to SessionStateHelper ### What changes were proposed in this pull request? Move session state utilities from trait FileFormat to SessionStateHelper ### Why are the changes needed? To addresses comments from #51398 (review) ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes #51411 from yaooqinn/SPARK-52704-F. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
cc @peter-toth |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Jul 14, 2025
…format options in TextBasedFileFormats ### What changes were proposed in this pull request? Simplify interoperations between SQLConf and file-format options in TextBasedFileFormats ### Why are the changes needed? - Reduce code duplication - Restore type annotation for IDE ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#51398 from yaooqinn/SPARK-52704. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Jul 14, 2025
…FileFormat to SessionStateHelper ### What changes were proposed in this pull request? Move session state utilities from trait FileFormat to SessionStateHelper ### Why are the changes needed? To addresses comments from apache#51398 (review) ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#51411 from yaooqinn/SPARK-52704-F. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
ksbeyer
pushed a commit
to ksbeyer/spark
that referenced
this pull request
Jul 14, 2025
…format options in TextBasedFileFormats ### What changes were proposed in this pull request? Simplify interoperations between SQLConf and file-format options in TextBasedFileFormats ### Why are the changes needed? - Reduce code duplication - Restore type annotation for IDE ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#51398 from yaooqinn/SPARK-52704. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
ksbeyer
pushed a commit
to ksbeyer/spark
that referenced
this pull request
Jul 14, 2025
…FileFormat to SessionStateHelper ### What changes were proposed in this pull request? Move session state utilities from trait FileFormat to SessionStateHelper ### Why are the changes needed? To addresses comments from apache#51398 (review) ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#51411 from yaooqinn/SPARK-52704-F. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Simplify interoperations between SQLConf and file-format options in TextBasedFileFormats
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
no