Skip to content

[SPARK-52704][SQL][FOLLOWUP] Move session state utilities from trait FileFormat to SessionStateHelper #51411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Jul 9, 2025

What changes were proposed in this pull request?

Move session state utilities from trait FileFormat to SessionStateHelper

Why are the changes needed?

To addresses comments from #51398 (review)

Does this PR introduce any user-facing change?

NO

How was this patch tested?

existing tests

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the SQL label Jul 9, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @yaooqinn .

@dongjoon-hyun
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member

cc @peter-toth

@yaooqinn yaooqinn deleted the SPARK-52704-F branch July 10, 2025 02:39
@yaooqinn
Copy link
Member Author

Thank you @dongjoon-hyun

asl3 pushed a commit to asl3/spark that referenced this pull request Jul 14, 2025
…FileFormat to SessionStateHelper

### What changes were proposed in this pull request?

Move session state utilities from trait FileFormat to SessionStateHelper

### Why are the changes needed?
To addresses comments from apache#51398 (review)

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
existing tests

### Was this patch authored or co-authored using generative AI tooling?
no

Closes apache#51411 from yaooqinn/SPARK-52704-F.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
ksbeyer pushed a commit to ksbeyer/spark that referenced this pull request Jul 14, 2025
…FileFormat to SessionStateHelper

### What changes were proposed in this pull request?

Move session state utilities from trait FileFormat to SessionStateHelper

### Why are the changes needed?
To addresses comments from apache#51398 (review)

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
existing tests

### Was this patch authored or co-authored using generative AI tooling?
no

Closes apache#51411 from yaooqinn/SPARK-52704-F.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants