[SPARK-52288][PS] Avoid INVALID_ARRAY_INDEX in split/rsplit when ANSI mode is on
#51006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
changed the title
split when ANSI mode is onsplit when ANSI mode is on
abhiips07
reviewed
May 26, 2025
|
|
||
| if ps.get_option("compute.ansi_mode_support"): | ||
| spark_columns = [ | ||
| F.try_element_at(scol, F.lit(i + 1)).alias(str(i)) for i in range(n + 1) |
There was a problem hiding this comment.
can we try to calculate f.lit(i+1) outside loop? since this might avoid function calls and object creation during loop execution
literals = [F.lit(i + 1) for i in range(n + 1)]
spark_columns = [F.try_element_at(scol, lit).alias(str(i)) for i, lit in enumerate(literals)]
There was a problem hiding this comment.
Thanks for suggestion!
There might not be a significant perf difference between creating F.lit inside the loop or beforehand, it's just wrapping a Python literal into a Spark expression, which aren’t executed immediately(just nodes in the DAG), and will be deduplicated by Catalyst. With that being said I’d like to keep the original for simplicity, but feel free to share if you have other opinions!
xinrong-meng
changed the title
split when ANSI mode is onsplit/split when ANSI mode is on
xinrong-meng
changed the title
split/split when ANSI mode is onsplit/rsplit when ANSI mode is on
xinrong-meng
force-pushed
the
arr_idx_enable
branch
from
21da378 to
3fc1656
Compare
|
@ueshin would you please review, thanks! |
HyukjinKwon
approved these changes
Jun 5, 2025
ueshin
approved these changes
Jun 6, 2025
|
Thanks! merging to master. |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…ANSI mode is on ### What changes were proposed in this pull request? Avoid INVALID_ARRAY_INDEX in `split`/`rsplit` when ANSI mode is on ### Why are the changes needed? Ensure pandas on Spark works well with ANSI mode on. Part of https://issues.apache.org/jira/browse/SPARK-52169. ### Does this PR introduce _any_ user-facing change? Yes. INVALID_ARRAY_INDEX no longer fails `split`/`rsplit` when ANSI mode is on ```py >>> spark.conf.get("spark.sql.ansi.enabled") 'true' >>> import pandas as pd >>> pser = pd.Series(["hello-world", "short"]) >>> psser = ps.from_pandas(pser) ``` FROM ```py >>> psser.str.split("-", n=1, expand=True) 25/05/28 14:52:10 ERROR Executor: Exception in task 10.0 in stage 2.0 (TID 15) org.apache.spark.SparkArrayIndexOutOfBoundsException: [INVALID_ARRAY_INDEX] The index 1 is out of bounds. The array has 1 elements. Use the SQL function `get()` to tolerate accessing element at invalid index and return NULL instead. SQLSTATE: 22003 == DataFrame == "__getitem__" was called from <stdin>:1 ... ``` TO ```py >>> psser.str.split("-", n=1, expand=True) 0 1 0 hello world 1 short None ``` ### How was this patch tested? Unit tests ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51006 from xinrong-meng/arr_idx_enable. Authored-by: Xinrong Meng <xinrong@apache.org> Signed-off-by: Takuya Ueshin <ueshin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid INVALID_ARRAY_INDEX in
split/rsplitwhen ANSI mode is onWhy are the changes needed?
Ensure pandas on Spark works well with ANSI mode on.
Part of https://issues.apache.org/jira/browse/SPARK-52169.
Does this PR introduce any user-facing change?
Yes. INVALID_ARRAY_INDEX no longer fails
split/rsplitwhen ANSI mode is onFROM
TO
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No