GH-46394: [C++][R] gcc-UBSAN errors on CRAN #46397

jonkeane · 2025-05-11T18:31:33Z

Rationale for this change

Fix gcc-UBSAN CI job to be correctly running, then fix the UBSAN error.

What changes are included in this PR?

Generalize our sanitizer jobs and use rhub's containers for this. wch/r-debug looks like it's out of date (hence why we didn't catch this), and it's easier to use a matrix of images with rhubarb anyway.
Initialize the _quoted variable — we could also cast it to boolean where the UBSAN popped, but this seems to be enough.

Are these changes tested?

Yes

Are there any user-facing changes?

No

GitHub Issue: [C++][R]: gcc-UBSAN errors on CRAN #46394

github-actions · 2025-05-11T18:32:03Z

⚠️ GitHub issue #46394 has been automatically assigned in GitHub to PR creator.

jonkeane · 2025-05-12T01:03:35Z

@github-actions crossbow submit test-r-linux-sanitizers

This should fail with the new rhub/gcc-asan job

github-actions · 2025-05-12T01:05:49Z

Revision: cbc67be

Submitted crossbow builds: ursacomputing/crossbow @ actions-faacd3047b

Task	Status
test-r-linux-sanitizers

jonkeane · 2025-05-12T01:08:02Z

@github-actions crossbow submit test-r-linux-sanitizers

And this one intializes the quoted variable

github-actions · 2025-05-12T01:10:32Z

Revision: f261c56

Submitted crossbow builds: ursacomputing/crossbow @ actions-b0ff1d4e40

Task	Status
test-r-linux-sanitizers

jonkeane · 2025-05-12T03:33:04Z

cpp/src/arrow/csv/parser.cc

-      : values_size_(0), values_capacity_(values_capacity), status_(Status::OK()) {
+      : values_size_(0),
+        values_capacity_(values_capacity),
+        quoted_(false),
+        saved_values_size_(0),
+        status_(Status::OK()) {


quoted_(false) and saved_values_size_(0) are the only additions here (the rest is whitespace)

jonkeane · 2025-05-12T03:48:14Z

Python / AMD64 Conda Python 3.10 Without Pandas is failing on main right now too, so not the changes in this PR

pitrou

+1, thanks for this @jonkeane . @kou Do you want to take a look at the CI setup changes here?

assignUser

Great change, thanks!

kou

+1

kou · 2025-05-13T00:43:18Z

dev/tasks/tasks.yml

        R_PRUNE_DEPS: TRUE
-      image: r-clang-asan
-
-  test-r-clang-ubsan:
-    ci: github
-    template: docker-tests/github.linux.yml
-    params:
-      env:
-        R_PRUNE_DEPS: TRUE
-      image: r-clang-ubsan
+        R_ORG: "rhub"
+        R_IMAGE: "{{ '${{ matrix.config.r_image }}' }}"
+        R_TAG: "latest"
+        ARROW_R_DEV: "TRUE"


Could you move this env: to github.linux.sanitizers.yml?
We don't need to customize them in tasks.yml, right?

I can, yeah. I was following other jobs here, but you're right that none of this varies at the tasks level.

jonkeane · 2025-05-13T02:55:03Z

@github-actions crossbow submit test-r-linux-sanitizers

github-actions · 2025-05-13T02:57:15Z

Revision: 45fcdd1

Submitted crossbow builds: ursacomputing/crossbow @ actions-6c92c64390

Task	Status
test-r-linux-sanitizers

conbench-apache-arrow · 2025-05-14T01:51:43Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 12424cd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them.

### Rationale for this change Fix gcc-UBSAN CI job to be correctly running, then fix the UBSAN error. ### What changes are included in this PR? * Generalize our sanitizer jobs and use rhub's containers for this. wch/r-debug looks like it's out of date (hence why we didn't catch this), and it's easier to use a matrix of images with rhubarb anyway. * Initialize the `_quoted` variable — we could also cast it to boolean where the UBSAN popped, but this seems to be enough. ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: #46394 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>

jonkeane requested review from assignUser, kou and raulcd as code owners May 11, 2025 18:31

github-actions bot added the awaiting committer review Awaiting committer review label May 11, 2025

jonkeane force-pushed the 46394-UBSAN branch 4 times, most recently from 479dbdd to db2d59a Compare May 11, 2025 23:05

Collapse the sanitizer jobs together

cbc67be

jonkeane force-pushed the 46394-UBSAN branch from db2d59a to cbc67be Compare May 12, 2025 01:02

github-actions bot added the Component: C++ label May 12, 2025

initialize quoted

c939280

jonkeane force-pushed the 46394-UBSAN branch from f261c56 to c939280 Compare May 12, 2025 03:02

jonkeane requested a review from pitrou May 12, 2025 03:30

jonkeane commented May 12, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels May 12, 2025

pitrou approved these changes May 12, 2025

View reviewed changes

assignUser approved these changes May 12, 2025

View reviewed changes

kou approved these changes May 13, 2025

View reviewed changes

github-actions bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting merge Awaiting merge labels May 13, 2025

Move env to action

45fcdd1

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels May 13, 2025

assignUser merged commit 12424cd into apache:main May 13, 2025
37 of 38 checks passed

assignUser removed the awaiting change review Awaiting change review label May 13, 2025

assignUser mentioned this pull request May 13, 2025

[C++][R]: gcc-UBSAN errors on CRAN #46394

Closed

jonkeane mentioned this pull request May 15, 2025

GH-40756: [C++] Remove dead Boost urls #46452

Merged

amoeba mentioned this pull request May 15, 2025

[R] CRAN packaging checklist for version 20.0.0.1 #46453

Open

34 tasks

GH-46394: [C++][R] gcc-UBSAN errors on CRAN #46397

GH-46394: [C++][R] gcc-UBSAN errors on CRAN #46397

Uh oh!

Conversation

jonkeane commented May 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented May 11, 2025

Uh oh!

jonkeane commented May 12, 2025

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

jonkeane commented May 12, 2025

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

jonkeane May 12, 2025

Choose a reason for hiding this comment

Uh oh!

jonkeane commented May 12, 2025

Uh oh!

pitrou left a comment

Choose a reason for hiding this comment

Uh oh!

assignUser left a comment

Choose a reason for hiding this comment

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

kou May 13, 2025

Choose a reason for hiding this comment

Uh oh!

jonkeane May 13, 2025

Choose a reason for hiding this comment

Uh oh!

jonkeane commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

Uh oh!

conbench-apache-arrow bot commented May 14, 2025

Uh oh!

Uh oh!

jonkeane commented May 11, 2025 •

edited

Loading