-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-40756: [C++] Remove dead Boost urls #46452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@github-actions crossbow submit -g cpp -g r |
Revision: fa17580 Submitted crossbow builds: ursacomputing/crossbow @ actions-27592e6acc |
There are many failures... but it seems they are not related to this. |
Thanks! Many of the r failures were resolved in #46443 |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 575cae6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them. |
One of the URLs is dead (https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.gz) and the sourceforge link is to the non-trimmed version. We are seeing these multiple downloads and fails on CRAN — I believe they get cleaned up so aren't the cause of those runners running out of space (See: https://www.r-project.org/nosvn/R.check/r-release-macos-x86_64/arrow-00install.txt and https://www.r-project.org/nosvn/R.check/r-oldrel-macos-x86_64/arrow-00install.html), but it still isn't great to have it download things we know will fail. ### Rationale for this change Don't download things we know will fail ### What changes are included in this PR? Removed two URLs ### Are these changes tested? Extensively. ### Are there any user-facing changes? No. * GitHub Issue: #40756 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
One of the URLs is dead (https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.gz) and the sourceforge link is to the non-trimmed version.
We are seeing these multiple downloads and fails on CRAN — I believe they get cleaned up so aren't the cause of those runners running out of space (See: https://www.r-project.org/nosvn/R.check/r-release-macos-x86_64/arrow-00install.txt and https://www.r-project.org/nosvn/R.check/r-oldrel-macos-x86_64/arrow-00install.html), but it still isn't great to have it download things we know will fail.
Rationale for this change
Don't download things we know will fail
What changes are included in this PR?
Removed two URLs
Are these changes tested?
Extensively.
Are there any user-facing changes?
No.