Skip to content

Conversation

LucasSte
Copy link

Problem

Downloads directly from the browser URL may fail in slow connections because Github now restricts them to a five minute window. One of the alternatives discussed in https://github.com/orgs/community/discussions/169381#discussioncomment-14105326 is using the Github REST API for the download.

This PR should fix anza-xyz/platform-tools#108 and anza-xyz/platform-tools#107.

This is a second approach to #8370, whereby we only use the Github REST API with the --install-only command.

Summary of Changes

  1. Add option --install-only, which downloads the tools from Github's REST API. It works with --force-tools-install and --tools-version.
  2. Add a hint to use --install-only when the download from the browser URL fails.

@LucasSte LucasSte requested a review from joncinque October 14, 2025 00:08
@LucasSte LucasSte marked this pull request as ready for review October 14, 2025 00:08
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.1%. Comparing base (6d5ab8f) to head (9b0eb1f).
⚠️ Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #8461     +/-   ##
=========================================
- Coverage    83.2%    83.1%   -0.1%     
=========================================
  Files         840      840             
  Lines      367886   367886             
=========================================
- Hits       306083   306075      -8     
- Misses      61803    61811      +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucasSte LucasSte requested a review from Lichtso October 14, 2025 10:16
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! This is going to be extremely useful. Just the typo from me

Lichtso
Lichtso previously approved these changes Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot download the platform-tools-linux-x86_64.tar.bz2

4 participants