-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/dialog): dialog name on mac only using aria-label #29264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
368d6fd
fix(material/dialog): dialog name on mac only using aria-label
essjay05 29d7012
fix(material/dialog): dialog name not read on macOS chrome & firefox
essjay05 9be3dad
fix(material/dialog): dialog name not read by screenreader on mac chr…
essjay05 f45a809
fix(material/dialog): dialog name not read by mac screenreader on chr…
essjay05 668fdd8
fix(material/dialog): dialog name not read by sr on mac chrome & firefox
essjay05 fa28b9a
refactor(material/dialog): dialog name not read by sr on mac with chr…
essjay05 45b03e2
fix(material/dialog): dialog name not read by screenreader on macos u…
essjay05 8437f51
fix(material/dialog): dialog name not read by screenreader on mac chr…
essjay05 859c8ad
fix(material/dialog): dialog name not read by sr on mac chrome or fir…
essjay05 1c981fb
fix(material/dialog): make reviewer suggested changes
essjay05 935b371
refactor(material/dialog): make suggested PR changes
essjay05 8530e1e
refactor(material/dialog): fix lint errors
essjay05 119d68b
refactor(material/dialog): updates prioritization order of aria-label…
essjay05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.