fix(material/dialog): dialog name on mac only using aria-label #29264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
the
dev-app preview
|
Deployed dev-app for 119d68b to: https://ng-dev-previews-comp--pr-angular-components-29264-dev-rjpcttjr.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
force-pushed
the
dialog-name-title-fix
branch
5 times, most recently
from
4d12a2a to
9a62391
Compare
essjay05
force-pushed
the
dialog-name-title-fix
branch
2 times, most recently
from
478e548 to
2342929
Compare
essjay05
force-pushed
the
dialog-name-title-fix
branch
from
bac212f to
c8c15d7
Compare
essjay05
requested review from
amysorto and
mmalerba
and removed request for
a team
essjay05
force-pushed
the
dialog-name-title-fix
branch
from
b830917 to
85be3e2
Compare
mmalerba
requested changes
Jun 30, 2024
essjay05
force-pushed
the
dialog-name-title-fix
branch
3 times, most recently
from
c17c4f0 to
6f11b5c
Compare
essjay05
force-pushed
the
dialog-name-title-fix
branch
3 times, most recently
from
8f902b4 to
fbf8f31
Compare
Totati
reviewed
Jul 16, 2024
Totati
reviewed
Jul 16, 2024
mmalerba
requested changes
Jul 17, 2024
essjay05
force-pushed
the
dialog-name-title-fix
branch
from
7f80749 to
8d66cc2
Compare
essjay05
force-pushed
the
dialog-name-title-fix
branch
2 times, most recently
from
74c5764 to
0535924
Compare
essjay05
force-pushed
the
dialog-name-title-fix
branch
3 times, most recently
from
1fccc53 to
d550311
Compare
essjay05
force-pushed
the
dialog-name-title-fix
branch
4 times, most recently
from
d3408cb to
735a605
Compare
Fixes bug with Angular Components Dialog component on Mac whether using Chrome or Firefox the screenreader does not read the dialog name/title unless it is using an aria-label. Updates the dialog-content-directives to read/apply the aria- labelledby and aria-describedby values if they exist. Fixes b/274674581
Fixes Angular Components Dialog component where the dialog name is not read by VoiceOver/screenreader on macOS chrome & firefox browsers. Attempts to retrieve any id associated with aria-labelledby or aria-describedby and taking the innerHTML or the aria-label of that element and applying that value to the dialog's aria-label. Fixes b/274674581
…ome or firefox Fixes bug in Angular Components Dialog component where the aria-labelledby and aria-describedby values are not being read by Chrome or Firefox when using a mac. This checks if there is an html attribute of aria-labelledby or aria-describedby and grabs the innerText or aria-label value and uses that value as the aria-label for the dialog only on mac using chrome or firefox. Fixes b/274674581
…ome and firefox Fixes Angular Components Dialog component where the mac screenreader is not reading the associated aria-labelledby id value as the dialog name/title. Fixes logic checking for macos so that the function_getDialogName() gets called when the value of the arialabelledby id element gets inserted into the aria-label value. Fixes b/274674581
Cleans up fix for Angular Component Dialog component's fix to update the dialog aria-label if the user's OS is a mac since mac using a chrome or firefox browser the screenreader does NOT read the dialog name if the value is portrayed by aria-labelledby or aria-describedby. Cleaned up console logs and unused attributes. Fixes b/274674581
…ome or firefox Cleans up unused variables and comments. Fixes b/274674581
…sing chrome or firefox Updates fix for Angular Components Dialog issue where the dialog name is not being read by the screenreader when specifically using macos (and potentially ios) screenreader when using chrome or firefox browsers. Removes unused commented out code and includes ios as part of the logic to call _getDialogName(). Fixes b/274674581
…ome or firefox Adds console.log tests to check new additions to Platform CDK which will be used for dialog name fix instead of previous logic. Fixes b/274674581
…efox Updates previous fix adding Windows and Linux checks to Platform CDK and replaces windows.navigator.userAgent with using Platform CDK check. Fixes b/274674581
Updates fix for Angular Components Dialog component to revert previous changes to aria-describedBy value to what it previously was to not upgrade its value to aria-label. Fixes _getDialogName function to return a string which gets applied to the ariaLabel config value. Fixes b/274674581
Updates previous fix to Angular Components Dialog component to remove unnecessary to our fix platform checks for WINDOWS and LINUX. Simplifies logic to check for platform in material/ dialog-container. Fixes b/274674581
Updates previous fix and removes unused import to fix lint error.
… adoption Updates to put aria-labelledby values as the priority and the aria-label as the backup.
essjay05
force-pushed
the
dialog-name-title-fix
branch
from
735a605 to
119d68b
Compare
|
Reverting this PR and closing as it looks like the aria-labelledby bug is specific to MacOS+Firefox even on a plain HTML/CSS/Vanilla Javascript Dialog and is not due to Angular Components. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug with Angular Components Dialog component on Mac whether using Chrome or Firefox the screenreader does not read the dialog name/title unless it is using an aria-label. Updates the dialog-content-directives to read/apply the aria- labelledby and aria-describedby values if they exist.
Fixes b/274674581