Skip to content

Conversation

@tfcollins
Copy link
Collaborator

@tfcollins tfcollins commented Mar 6, 2025

Description

Add filter APIs for AD9084 with tests

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Travis F. Collins <travis.collins@analog.com>
Signed-off-by: Travis F. Collins <travis.collins@analog.com>
@tfcollins tfcollins requested a review from mhennerich March 6, 2025 01:44
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

Test Results

1 662 tests  +2     426 ✅  - 2   11m 55s ⏱️ -9s
    1 suites ±0   1 232 💤 ±0 
    1 files   ±0       4 ❌ +4 

For more details on these failures, see this check.

Results for commit 8277de7. ± Comparison against base commit 80796c5.

This pull request removes 4 and adds 6 tests. Note that renamed tests count towards both.
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[0.0, 22.5, 4.5, 21.0, 32.5, 32.5, 25.0, 11.5, 10.5, 16.5]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[16.0, 11.0, 22.0, 13.5, 29.0, 6.5, 33.5, 0.5, 31.0, 32.0]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-23.35, -17.85, -1.35, -23.95, -37.1, -3.05, -31.6, -21.55, -2.7, -0.35]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-23.8, -16.5, -8.5, -10.3, -23.65, -17.3, -13.55, -14.65, -25.85, -36.95]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]
test.test_ad9084 ‑ test_cfilt
test.test_ad9084 ‑ test_pfilt
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[14.0, 31.0, 24.5, 6.5, 20.0, 32.0, 33.0, 27.5, 28.5, 20.0]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[33.0, 31.0, 32.5, 34.0, 1.0, 17.5, 28.0, 9.0, 11.0, 12.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-5.0, -33.6, -13.15, -10.85, -38.35, -36.3, -20.2, -7.95, -13.05, -34.9]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-30.7, -25.4, -17.55, -4.4, -1.9, -37.25, -37.15, -8.8, -16.35, -25.75]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants