Skip to content

Update READMEs with VADJ info and modify the IOSTANDARD from LVCMOS25 to LVCMOS18 in constraints for ad7134_fmc #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update READMEs with VADJ info and modify the IOSTANDARD from LVCMOS25 to LVCMOS18 in constraints for ad7134_fmc #1825

wants to merge 2 commits into from

Conversation

mandrica
Copy link
Collaborator

@mandrica mandrica commented Jul 7, 2025 •
edited
Loading

PR Description

Added VADJ info and modify the IOSTANDARD from LVCMOS25 to LVCMOS33 in constraints for ad7134_fmc.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@mandrica mandrica requested review from sarpadi and PIoandan as code owners July 7, 2025 13:36
@mandrica mandrica added the doc label Jul 7, 2025
@mandrica mandrica requested review from IuliaCMoldovan and StancaPop and removed request for sarpadi and PIoandan July 7, 2025 13:36
@mandrica mandrica changed the title Update READMEs with VADJ info and modify the IOSTANDARD from LVCMOS25 to LVCMOS18 in constraint for ad7134_fmc Update READMEs with VADJ info and modify the IOSTANDARD from LVCMOS25 to LVCMOS18 in constraints for ad7134_fmc Jul 7, 2025
IuliaCMoldovan
IuliaCMoldovan reviewed Jul 9, 2025
View reviewed changes
projects/ad7134_fmc/zed/system_project.tcl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update copyright year

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

IuliaCMoldovan
IuliaCMoldovan reviewed Jul 9, 2025
View reviewed changes
projects/ad7134_fmc/zed/system_constr.xdc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the build pass locally?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@mandrica mandrica force-pushed the readme_ad7134_fmc_vadj branch from af723b7 to f91e393 Compare July 9, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan left review comments

@StancaPop StancaPop Awaiting requested review from StancaPop

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mandrica @IuliaCMoldovan