Skip to content

(Merge after 0.4 is released) Remove Const.normalize #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

whitequark
Copy link
Member

Closes #754.

@whitequark whitequark added this to the 0.5 milestone Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2f3c54) 83.93% compared to head (3775b1a) 83.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
+ Coverage   83.93%   83.98%   +0.04%     
==========================================
  Files          55       55              
  Lines        8057     8049       -8     
  Branches     1966     1962       -4     
==========================================
- Hits         6763     6760       -3     
+ Misses       1082     1077       -5     
  Partials      212      212              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitequark whitequark marked this pull request as ready for review December 13, 2023 09:44
@whitequark whitequark force-pushed the remove-const-normalize branch from e002f24 to 3775b1a Compare December 13, 2023 09:47
@whitequark whitequark enabled auto-merge December 13, 2023 09:47
@whitequark whitequark disabled auto-merge December 13, 2023 09:49
@whitequark whitequark added this pull request to the merge queue Dec 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 13, 2023
@whitequark
Copy link
Member Author

(Confusingly, merged as a part of #961.)

@whitequark whitequark closed this Dec 13, 2023
@whitequark whitequark deleted the remove-const-normalize branch December 13, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Implement RFC 5: Remove Const.normalize
1 participant