(Merge after 0.4 is released) Remove non-FWFT FIFOs #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanda-phi
force-pushed
the
remove-fwft
branch
from
0de2269 to
0775fb5
Compare
3 tasks
whitequark
changed the title
|
Note: this will need another PR to add a changelog entry after merging. |
wanda-phi
force-pushed
the
remove-fwft
branch
from
0775fb5 to
f4190b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
==========================================
- Coverage 86.62% 86.58% -0.05%
==========================================
Files 41 41
Lines 7043 7035 -8
Branches 1678 1675 -3
==========================================
- Hits 6101 6091 -10
- Misses 779 782 +3
+ Partials 163 162 -1 ☔ View full report in Codecov by Sentry. |
|
@wanda-phi Changelog? |
wanda-phi
force-pushed
the
remove-fwft
branch
from
f4190b6 to
e81554e
Compare
whitequark
approved these changes
Dec 13, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #875.
Note: this depends on #840 and will fail tests without it.