Skip to content

back.rtlil: Emit proper source location for port-signals. #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

wanda-phi
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.40%. Comparing base (1cb9d43) to head (562f7e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
+ Coverage   87.37%   87.40%   +0.02%     
==========================================
  Files          43       43              
  Lines        8629     8631       +2     
  Branches     2043     2043              
==========================================
+ Hits         7540     7544       +4     
+ Misses        899      898       -1     
+ Partials      190      189       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fills in the missing source locations.

@whitequark whitequark added this pull request to the merge queue Feb 27, 2024
Merged via the queue into amaranth-lang:main with commit c30585b Feb 27, 2024
@wanda-phi wanda-phi deleted the port-src-loc branch February 27, 2024 11:49
@whitequark whitequark added this to the 0.5 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants