back.rtlil: Remove code allowing internal yosys cells in Instance.
#1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
==========================================
+ Coverage 87.34% 87.37% +0.03%
==========================================
Files 43 43
Lines 8632 8629 -3
Branches 2044 2043 -1
==========================================
Hits 7540 7540
+ Misses 901 899 -2
+ Partials 191 190 -1 ☔ View full report in Codecov by Sentry. |
whitequark
reviewed
Feb 27, 2024
This was allowed only because Amaranth used it internally. Now that all uses are gone, let's just disallow it entirely.
wanda-phi
force-pushed
the
public-instance-only
branch
from
65e6914 to
d4b45f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was allowed only because Amaranth used it internally. Now that all uses are gone, let's just disallow it entirely.