Skip to content

sim.pysim: Only close VCD/GTKW files if we opened them ourselves. #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

wanda-phi
Copy link
Member

Fixes #1107.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.90%. Comparing base (a586df8) to head (04be176).

Files Patch % Lines
amaranth/sim/pysim.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1156   +/-   ##
=======================================
  Coverage   85.89%   85.90%           
=======================================
  Files          43       43           
  Lines        8687     8691    +4     
  Branches     2067     2067           
=======================================
+ Hits         7462     7466    +4     
  Misses       1024     1024           
  Partials      201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@whitequark whitequark added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2024
@whitequark whitequark added this pull request to the merge queue Feb 27, 2024
Merged via the queue into amaranth-lang:main with commit a725282 Feb 27, 2024
@wanda-phi wanda-phi deleted the vcd-close-fix branch February 27, 2024 09:43
@whitequark whitequark added this to the 0.5 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

PySim VCDWriter is useless with io.StringIO
2 participants