Skip to content

hdl.ir: associate statements with domains. #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

wanda-phi
Copy link
Member

Fixes #1079.

This does not remove Fragment.drivers — that will be done when the new IR lands and the remaining uses in hdl._ir can be killed.

This also does not remove the special signals inside Property — they are still used within RTLIL backend, and likewise will be removed when the new IR lands.

@wanda-phi wanda-phi requested a review from whitequark as a code owner February 9, 2024 01:17
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ace7aea) 86.99% compared to head (fec1fbf) 87.06%.

Files Patch % Lines
amaranth/hdl/_ir.py 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
+ Coverage   86.99%   87.06%   +0.06%     
==========================================
  Files          41       41              
  Lines        7161     7196      +35     
  Branches     1705     1722      +17     
==========================================
+ Hits         6230     6265      +35     
  Misses        768      768              
  Partials      163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@whitequark whitequark added this to the 0.5 milestone Feb 9, 2024
@whitequark whitequark added this pull request to the merge queue Feb 9, 2024
Merged via the queue into amaranth-lang:main with commit 6e06fc0 Feb 9, 2024
@wanda-phi wanda-phi deleted the stmt-domain branch February 9, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Fragment to have a mapping from statements to domains
2 participants