Add readonly option #415
Merged
Add readonly option #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new marker can be used to create restricted execution environments e.g., EVAL_RO, FUNCTION_RO Signed-off-by: Maximilian Frank <1375575+max-frank@users.noreply.github.com>
The readonly command list is based on the JSON data in https://github.com/redis/redis/tree/acbcaae530035aab5480756e8e29e075398ea931/src/commands A command was deemed as readonly if the field contained Signed-off-by: Maximilian Frank <1375575+max-frank@users.noreply.github.com>
This was referenced Sep 20, 2025
|
Thanks! I made some minor changes. Looking forward to the follow up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add support for marking redis commands as
ReadOnlyand marked 70 commands as read only.The readonly command list is based on the JSON data in
A command was deemed as readonly if the field contained
WHY
This is a first step for implementing support for EVAL_RO, EVALSHA_RO (#414) as the read only marker can be used for constructing a restricted execution environment. Other than eval/function commands this flag could also be useful for adding support for a readonly replica operation mode. Such a mode could be useful in complex test scenarios were a user might want to ensure that write commands are not sent to a replica.