Add evalro support #416
Open
Add evalro support #416
+202
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-frank
force-pushed
the
add-evalro-support
branch
5 times, most recently
from
4025291 to
957d2d2
Compare
max-frank
force-pushed
the
add-evalro-support
branch
from
957d2d2 to
1d1868b
Compare
Signed-off-by: Maximilian Frank <1375575+max-frank@users.noreply.github.com>
max-frank
force-pushed
the
add-evalro-support
branch
from
1d1868b to
dfbed22
Compare
|
hi @max-frank , thanks for the previous PR, what's the status of this one? No rush, just curious. |
Ah this one should be good to go as well unless I missed something on regards to the _RO spec |
|
ok, thanks! I'll check later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add support for script commands read only variants (
EVAL_ROandEVALSHA_RO). The execution logic is the same as the standard commands, but these command will error if any command writing to redis is invoked.Additionally
IsRegisteredCommandallowing to check if a command is registered on the miniredis server. This is used to ensure unknown command errors are correctly returned instead of read only mode errors, but could also be used later for asserting new commands are loaded after module load commands are executed.WHY
To support the new commands
Note
This PR depends on #415 and will be rebased once it is merged