Skip to content

fix: add required og:type to metadata #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: Build
on: [push]
on:
push:
pull_request:
types: [opened, synchronize, reopened]

env:
CI_BUILD_NUM: ${{ github.run_id }}
Expand All @@ -14,7 +17,7 @@ jobs:
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: "20.x"
- run: npm ci
- run: npm run lint
- run: npm test
Expand All @@ -38,7 +41,7 @@ jobs:
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: "20.x"
- run: npm ci
- run: npm run semantic-release
env:
Expand Down
1 change: 1 addition & 0 deletions src/steps/extract-metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ export default function extractMetaData(state, req) {
const metadata = {
description: meta.description,
keywords: meta.keywords,
'og:type': meta['og:type'] || 'website',
'og:title': meta.title,
'og:description': meta.description,
'og:url': meta.url,
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/description-blockquote.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<title>How to Create Branded Stories in Adobe Spark</title>
<link rel="canonical" href="https://helix-pages.com/description-blockquote">
<meta name="description" content="Branded stories are here! Adobe Spark allows you to inject more creativity into your visual stories than ever before. Using Adobe Spark, make your designs, ...">
<meta property="og:type" content="website">
<meta property="og:title" content="How to Create Branded Stories in Adobe Spark">
<meta property="og:description" content="Branded stories are here! Adobe Spark allows you to inject more creativity into your visual stories than ever before. Using Adobe Spark, make your designs, ...">
<meta property="og:url" content="https://helix-pages.com/description-blockquote">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/description-long.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<head><title>Hello</title>
<link rel="canonical" href="https://helix-pages.com/description-long">
<meta name="description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis scelerisque orci vitae tellus accumsan posuere. Phasellus eget urna velit. Ut vulputate eros aliquam suscipit vehicula. ...">
<meta property="og:type" content="website">
<meta property="og:title" content="Hello">
<meta property="og:description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis scelerisque orci vitae tellus accumsan posuere. Phasellus eget urna velit. Ut vulputate eros aliquam suscipit vehicula. ...">
<meta property="og:url" content="https://helix-pages.com/description-long">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/description.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<title>Return of the raspberry: New Zealand’s favourite combo: Foo-Bar New Zealand</title>
<link rel="canonical" href="https://helix-pages.com/description">
<meta name="description" content="Description override">
<meta property="og:type" content="website">
<meta property="og:title" content="Return of the raspberry: New Zealand’s favourite combo: Foo-Bar New Zealand">
<meta property="og:description" content="Description override">
<meta property="og:url" content="https://helix-pages.com/description">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/empty-table-row.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<title>ACME CORP</title>
<link rel="canonical" href="https://www.adobe.com/html-only">
<meta name="description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed euismod, urna eu tempor congue, nisi erat condimentum nunc, eget tincidunt nisl nunc euismod.">
<meta property="og:type" content="website">
<meta property="og:title" content="ACME CORP">
<meta property="og:description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed euismod, urna eu tempor congue, nisi erat condimentum nunc, eget tincidunt nisl nunc euismod.">
<meta property="og:url" content="https://www.adobe.com/html-only">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/gt-many-refs.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<title>ACME CORP</title>
<link rel="canonical" href="https://www.adobe.com/gt-many-refs">
<meta name="description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed euismod, urna eu tempor congue, nisi erat condimentum nunc, eget tincidunt nisl nunc euismod.">
<meta property="og:type" content="website">
<meta property="og:title" content="ACME CORP">
<meta property="og:description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed euismod, urna eu tempor congue, nisi erat condimentum nunc, eget tincidunt nisl nunc euismod.">
<meta property="og:url" content="https://www.adobe.com/gt-many-refs">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/head-with-script.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<title>ACME CORP</title>
<link rel="canonical" href="https://www.adobe.com/head-with-script">
<meta name="description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed euismod, urna eu tempor congue, nisi erat condimentum nunc, eget tincidunt nisl nunc euismod.">
<meta property="og:type" content="website">
<meta property="og:title" content="ACME CORP">
<meta property="og:description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed euismod, urna eu tempor congue, nisi erat condimentum nunc, eget tincidunt nisl nunc euismod.">
<meta property="og:url" content="https://www.adobe.com/head-with-script">
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/content/icons-ignored.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ <h1 id="icons">Icons</h1>
<p><a href="https://example.test/:urn:">https://example.test/:urn:</a></p>
<p>urn:aaid:sc:VA6C2:ac6066f3-fd1d-4e00-bed3-fa3aa6d981d8</p>
</div>
</main>
</main>
2 changes: 1 addition & 1 deletion test/fixtures/content/icons.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ <h1 id="icons">Icons</h1>
<p>Hello <span class="icon icon-check"></span> mark.</p>
<p>Team<span class="icon icon-rocket"></span>blasting off again.</p>
</div>
</main>
</main>
1 change: 1 addition & 0 deletions test/fixtures/content/image-from-meta-rewrite-link.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<title>ACME CORP</title>
<link rel="canonical" href="https://www.adobe.com/image-from-meta-rewrite-link">
<meta name="description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed euismod, urna eu tempor congue, nisi erat condimentum nunc, eget tincidunt nisl nunc euismod.">
<meta property="og:type" content="website">
<meta property="og:title" content="ACME CORP">
<meta property="og:description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed euismod, urna eu tempor congue, nisi erat condimentum nunc, eget tincidunt nisl nunc euismod.">
<meta property="og:url" content="https://www.adobe.com/image-from-meta-rewrite-link">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/image-from-meta-rewrite.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<title>Hero</title>
<link rel="canonical" href="https://helix-pages.com/image-from-meta-rewrite">
<meta property="og:type" content="website">
<meta property="og:title" content="Hero">
<meta property="og:url" content="https://helix-pages.com/image-from-meta-rewrite">
<meta property="og:image" content="https://helix-pages.com/media_176cf630873d24a275d9f500a15fd32abca5be225.jpeg?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/image-from-meta.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<title>Hero</title>
<link rel="canonical" href="https://helix-pages.com/image-from-meta">
<meta property="og:type" content="website">
<meta property="og:title" content="Hero">
<meta property="og:url" content="https://helix-pages.com/image-from-meta">
<meta property="og:image" content="https://helix-pages.com/media_67af739484f3d60dc64e306ccbf9b90a6d63a24c.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/image-no-alt.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<title>Hero</title>
<link rel="canonical" href="https://helix-pages.com/image-no-alt">
<meta property="og:type" content="website">
<meta property="og:title" content="Hero">
<meta property="og:url" content="https://helix-pages.com/image-no-alt">
<meta property="og:image" content="https://helix-pages.com/media_a22b1a53edf9b324465d14b2efca169a25d564a0.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/image-with-title.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<title>Hero</title>
<link rel="canonical" href="https://helix-pages.com/image-with-title">
<meta property="og:type" content="website">
<meta property="og:title" content="Hero">
<meta property="og:url" content="https://helix-pages.com/image-with-title">
<meta property="og:image" content="https://helix-pages.com/media_a22b1a53edf9b324465d14b2efca169a25d564a0.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/image.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<title>Hero</title>
<link rel="canonical" href="https://helix-pages.com/image">
<meta property="og:type" content="website">
<meta property="og:title" content="Hero">
<meta property="og:url" content="https://helix-pages.com/image">
<meta property="og:image" content="https://helix-pages.com/media_a22b1a53edf9b324465d14b2efca169a25d564a0.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/large.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<title>bin/magento(Magento Open Source) | Adobe Commerce</title>
<link rel="canonical" href="https://www.adobe.com/large">
<meta name="description" content="Magento Open Source bin/magento 명령줄 도구에 사용할 수 있는 모든 명령, 인수 및 옵션에 대해 알아봅니다.">
<meta property="og:type" content="website">
<meta property="og:title" content="bin/magento(Magento Open Source) | Adobe Commerce">
<meta property="og:description" content="Magento Open Source bin/magento 명령줄 도구에 사용할 수 있는 모든 명령, 인수 및 옵션에 대해 알아봅니다.">
<meta property="og:url" content="https://www.adobe.com/large">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/meta-response-headers.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<head>
<title>Hello Meta</title>
<link href="https://helix-pages.com/meta-response-headers" rel="canonical">
<meta property="og:type" content="website">
<meta content="Hello Meta" property="og:title">
<meta content="https://helix-pages.com/meta-response-headers" property="og:url">
<meta content="https://helix-pages.com/default-meta-image.png?width=1200&amp;format=pjpg&amp;optimize=medium" property="og:image">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/no-head-html.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<title>ACME CORP</title>
<link rel="canonical" href="https://www.adobe.com/no-head-html">
<meta name="description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed euismod, urna eu tempor congue, nisi erat condimentum nunc, eget tincidunt nisl nunc euismod.">
<meta property="og:type" content="website">
<meta property="og:title" content="ACME CORP">
<meta property="og:description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed euismod, urna eu tempor congue, nisi erat condimentum nunc, eget tincidunt nisl nunc euismod.">
<meta property="og:url" content="https://www.adobe.com/no-head-html">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-block-canonical.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<title>Pricing | Adobe Spark</title>
<link rel="canonical" href="https://www.adobe.com/express/">
<meta name="description" content="Adobe Spark lets you easily search from thousands of free photos, use themes, add filters, pick fonts, add text to photos, and make videos on mobile and web.">
<meta property="og:type" content="website">
<meta property="og:title" content="Pricing | Adobe Spark">
<meta property="og:description" content="Adobe Spark lets you easily search from thousands of free photos, use themes, add filters, pick fonts, add text to photos, and make videos on mobile and web.">
<meta property="og:url" content="https://helix-pages.com/page-metadata-block-canonical">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-block-empty-url.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<title>Pricing | Adobe Spark</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-block-empty-url">
<meta name="description" content="Adobe Spark lets you easily search from thousands of free photos, use themes, add filters, pick fonts, add text to photos, and make videos on mobile and web.">
<meta property="og:type" content="website">
<meta property="og:title" content="Pricing | Adobe Spark">
<meta property="og:description" content="Adobe Spark lets you easily search from thousands of free photos, use themes, add filters, pick fonts, add text to photos, and make videos on mobile and web.">
<meta property="og:url" content="&quot;&quot;">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-block-html.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<title>Pricing | Adobe Spark</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-block-html">
<meta name="description" content="Adobe Spark lets you easily search from thousands of free photos, use themes, add filters, pick fonts, add text to photos, and make videos on mobile and web.">
<meta property="og:type" content="website">
<meta property="og:title" content="Pricing | Adobe Spark">
<meta property="og:description" content="Adobe Spark lets you easily search from thousands of free photos, use themes, add filters, pick fonts, add text to photos, and make videos on mobile and web.">
<meta property="og:url" content="https://helix-pages.com/page-metadata-block-html">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-block-multi-a.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<head><title>Metadata Block Test</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-block-multi-a">
<meta property="og:type" content="website">
<meta property="og:title" content="Metadata Block Test">
<meta property="og:url" content="https://helix-pages.com/page-metadata-block-multi-a">
<meta property="og:image" content="https://helix-pages.com/default-meta-image.png?width=1200&amp;format=pjpg&amp;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-block-multi-ol.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<head><title>Metadata Block Test</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-block-multi-ol">
<meta property="og:type" content="website">
<meta property="og:title" content="Metadata Block Test">
<meta property="og:url" content="https://helix-pages.com/page-metadata-block-multi-ol">
<meta property="og:image" content="https://helix-pages.com/default-meta-image.png?width=1200&amp;format=pjpg&amp;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-block-multi-p.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<head><title>Metadata Block Test</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-block-multi-p">
<meta property="og:type" content="website">
<meta property="og:title" content="Metadata Block Test">
<meta property="og:url" content="https://helix-pages.com/page-metadata-block-multi-p">
<meta property="og:image" content="https://helix-pages.com/default-meta-image.png?width=1200&amp;format=pjpg&amp;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-block-multi-ul.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<head><title>Metadata Block Test</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-block-multi-ul">
<meta property="og:type" content="website">
<meta property="og:title" content="Metadata Block Test">
<meta property="og:url" content="https://helix-pages.com/page-metadata-block-multi-ul">
<meta property="og:image" content="https://helix-pages.com/default-meta-image.png?width=1200&amp;format=pjpg&amp;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-block.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<link rel="canonical" href="https://www.adobe.com/blog/page-metadata-block">
<meta name="description" content="Meta description">
<meta name="keywords" content="Foo, Bar, Baz">
<meta property="og:type" content="website">
<meta property="og:title" content="Meta title">
<meta property="og:description" content="Meta description">
<meta property="og:image" content="https://www.adobe.com/default-meta-image.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-content-blocks.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<link rel="canonical"
href="https://super-test--helix-pages--adobe.hlx3.page/marketing/page-metadata-content-blocks">
<meta name="description" content="Want to know how to make a picture smaller, vertical, or horizontal? Use our free online photo resizer to adjust the size and dimensions of ...">
<meta property="og:type" content="website">
<meta property="og:title" content="Resize your image for free.">
<meta property="og:description" content="Want to know how to make a picture smaller, vertical, or horizontal? Use our free online photo resizer to adjust the size and dimensions of ...">
<meta property="og:url" content="https://super-test--helix-pages--adobe.hlx3.page/marketing/page-metadata-content-blocks">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-json.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<title>Metadata JSON Test</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-json">
<meta name="keywords" content="Baz, Bar, Foo">
<meta property="og:type" content="website">
<meta property="og:title" content="Metadata JSON Test">
<meta property="og:url" content="https://helix-pages.com/page-metadata-json">
<meta property="og:image" content="https://helix-pages.com/media_cf867e391c0b433ec3d416c979aafa1f8e4aae9c.png?width=1200&amp;format=pjpg&amp;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-jsonld-error.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<head>
<title>Home | Helix Project Boilerplate</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-jsonld-error">
<meta property="og:type" content="website">
<meta property="og:title" content="Home | Helix Project Boilerplate">
<meta property="og:url" content="https://helix-pages.com/page-metadata-jsonld-error">
<meta property="og:image" content="https://helix-pages.com/default-meta-image.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-jsonld-global.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<head>
<title>Global JSON LD Test</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-jsonld-global">
<meta property="og:type" content="website">
<meta property="og:title" content="Global JSON LD Test">
<meta property="og:url" content="https://helix-pages.com/page-metadata-jsonld-global">
<meta property="og:image" content="https://helix-pages.com/default-meta-image.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-jsonld-list.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<head>
<title>Home | Helix Project Boilerplate</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-jsonld-list">
<meta property="og:type" content="website">
<meta property="og:title" content="Home | Helix Project Boilerplate">
<meta property="og:url" content="https://helix-pages.com/page-metadata-jsonld-list">
<meta property="og:image" content="https://helix-pages.com/default-meta-image.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-jsonld-multi.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<head>
<title>Home | Helix Project Boilerplate</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-jsonld-multi">
<meta property="og:type" content="website">
<meta property="og:title" content="Home | Helix Project Boilerplate">
<meta property="og:url" content="https://helix-pages.com/page-metadata-jsonld-multi">
<meta property="og:image" content="https://helix-pages.com/default-meta-image.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-jsonld-xss.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<head>
<title>Home | Helix Project Boilerplate</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-jsonld-xss">
<meta property="og:type" content="website">
<meta property="og:title" content="Home | Helix Project Boilerplate">
<meta property="og:url" content="https://helix-pages.com/page-metadata-jsonld-xss">
<meta property="og:image" content="https://helix-pages.com/default-meta-image.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-jsonld.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<head>
<title>Home | Helix Project Boilerplate</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-jsonld">
<meta property="og:type" content="website">
<meta property="og:title" content="Home | Helix Project Boilerplate">
<meta property="og:url" content="https://helix-pages.com/page-metadata-jsonld">
<meta property="og:image" content="https://helix-pages.com/default-meta-image.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-no-fallback.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<title></title>
<meta name="description" content="">
<meta property="og:type" content="website">
<meta property="og:title" content="">
<meta property="og:description" content="">
<meta property="og:url" content="">
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/content/page-metadata-twitter-fallback.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<title>Home | Helix Project Boilerplate</title>
<link rel="canonical" href="https://helix-pages.com/page-metadata-twitter-fallback">
<meta name="description" content="Your forked repo is setup as a helix project and you are ready to start developing.">
<meta property="og:type" content="website">
<meta property="og:title" content="og title">
<meta property="og:description" content="og description">
<meta property="og:url" content="https://helix-pages.com/page-metadata-twitter-fallback">
Expand Down
Loading
Loading