Skip to content

fix: add required og:type to metadata #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

hparra
Copy link
Contributor

@hparra hparra commented Sep 12, 2024

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Fixes #685

Thanks for contributing!

@hparra hparra changed the title Add default og:type to metadata fix: add required og:type to metadata Sep 12, 2024
@hparra
Copy link
Contributor Author

hparra commented Sep 12, 2024

npm test passed locally. not sure why ci is not running here.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7959603) to head (d358d4f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #686   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         3593      3594    +1     
=========================================
+ Hits          3593      3594    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please revert the changes in .github/workflows/main.yaml they are unrelated to the issue
  • we need to discuss this first in an issue, why adding og:type is needed.

@hparra
Copy link
Contributor Author

hparra commented Sep 12, 2024

  • please revert the changes in .github/workflows/main.yaml they are unrelated to the issue

@tripodsan #687

This reverts commit d358d4f.
@tripodsan
Copy link
Contributor

won't fix.

@tripodsan tripodsan closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata missing required og:type
2 participants