SMQ-1744 - Add new error and new error types #3169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
arvindh123
force-pushed
the
error_handling
branch
from
94250b6 to
be07061
Compare
Signed-off-by: Arvindh <arvindh91@gmail.com>
felixgateru
reviewed
Nov 4, 2025
Comment on lines
+187
to
+201
| switch retErr := err.(type) { | ||
| case errors.RequestError: | ||
| w.WriteHeader(http.StatusBadRequest) | ||
| if err := json.NewEncoder(w).Encode(retErr); err != nil { | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| } | ||
| return | ||
| case errors.AuthNError, errors.AuthZError: | ||
| w.WriteHeader(http.StatusUnauthorized) | ||
| if err := json.NewEncoder(w).Encode(retErr); err != nil { | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| } | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Will this type switch replace the big switch case defined below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes