Skip to content

Fix two memory use errors detected by ASAN #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

Fix two memory use errors detected by ASAN #1514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
281c7ed
Fix invalid memory use
asl Aug 20, 2025
182d7cf
Merge branch 'main' into fix-memory-bugs
asl Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/src/ssw/ssw_cpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ int CalculateNumberMismatch(
int8_t const *query,
const int& query_len) {

ref += al->ref_begin;
query += al->query_begin;
ref += (al->ref_begin > 0 ? al->ref_begin : 0);
query += (al->query_begin > 0 ? al->query_begin : 0);
int mismatch_length = 0;

std::vector<uint32_t> new_cigar;
Expand Down
2 changes: 1 addition & 1 deletion src/common/modules/simplification/topological_edge_conditions.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ UniquePathLengthLowerBound(const Graph &g, size_t min_length) {
template<class Graph>
EdgePredicate<Graph>
UniqueIncomingPathLengthLowerBound(const Graph &g, size_t min_length) {
return [&] (typename Graph::EdgeId e) {
return [&g, min_length] (typename Graph::EdgeId e) {
typename Graph::VertexId v = g.EdgeStart(e);
return g.CheckUniqueIncomingEdge(v) &&
UniquePathLengthLowerBound(g, min_length)(g.GetUniqueIncomingEdge(v));
Expand Down
Loading