Skip to content

Revise payment tutorials, add/remove screenshots #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2025

Conversation

DennisDawson
Copy link
Contributor

refactored code, new CSS, only one active account at a time, but radio button allows switching between two accounts in the active fields.

Copy link
Collaborator

@oeggert oeggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks pretty good, but there are a couple points I have that apply across all functions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a button to fund an existing account with additional XRP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of an easy way to do that using the faucet. If I want to add XRP to an account, I can just create another account and send some XRP. Accounts that run out of XRP should try sending smaller amounts when testing.

let net = getNet()
const client = new xrpl.Client(net)
await client.connect()
let results = `\nConnected to ${net}.`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let results = `\nConnected to ${net}.`
let results += `===Getting Account===\nConnected to ${net}.`

This suggestion applies to all instances that add to the result field. I think it's worth keeping a log of all actions that take place, so ensuring all results are += and not overridden with =. It'd also like to see a more pronounced headers to identify the type of function that's being called to help differentiate info in the logs. So for an offer create transaction, it starts with something like ===Creating Offer=== and then has a line break for subsequent metadata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made these changes.

@maria-robobug
Copy link
Contributor

maria-robobug commented Apr 25, 2025

Question about how we reference code snippets, should we not use this format now?

{% code-snippet file="/_code-samples/modular-tutorials/send-checks.js" language="js" from="async function sendCheck() {" before="let check_amount = amountField.value" /%}

@oeggert oeggert mentioned this pull request Apr 29, 2025
Copy link

socket-security bot commented May 2, 2025

Caution

Review the following alerts detected in dependencies.

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Block Critical
fs@0.0.1-security is Known malware.

Note: Package has been removed from the npm registry due to security concerns.

This is a placeholder package published by the npm security team to prevent malicious usage of the package name.
The original package likely contained harmful code.

From: _code-samples/tx-serialization/js/package.jsonnpm/fs@0.0.1-security

ℹ Read more on: This package | This alert | What is known malware?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: It is strongly recommended that malware is removed from your codebase.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/fs@0.0.1-security. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@DennisDawson DennisDawson requested a review from oeggert May 7, 2025 20:51
oeggert
oeggert previously approved these changes May 12, 2025
Copy link
Collaborator

@oeggert oeggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

maria-robobug
maria-robobug previously approved these changes May 13, 2025
@DennisDawson DennisDawson dismissed stale reviews from maria-robobug and oeggert via ec1f33d May 13, 2025 14:31
@DennisDawson DennisDawson merged commit 79e1612 into master May 13, 2025
4 of 6 checks passed
@DennisDawson DennisDawson deleted the refactor_payment_modular_tuts branch May 13, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants