Permissioned domains #3102
Merged
Permissioned domains #3102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maria-robobug After #3091 is merged, I'll update whatever changes happened there into this PR. I expect only the code to change on the backend, the frontend functionality and tutorial page should stay the same, so those can be safely reviewed. |
docs/tutorials/javascript/decentralized-finance/create-permissioned-domains.md
Outdated
Show resolved
Hide resolved
|
|
||
| // Get credential type - convert string to hex if needed | ||
| let credentialType = credentialTypeField.value; | ||
| if (!/^[0-9A-F]+$/i.test(credentialType)) { |
There was a problem hiding this comment.
We can use convenience functions from the @xrplf/isomorphic package to convert string to hex or hex back to string: stringToHex, hexToString.
Also mentioned in xrpl.js reference:
https://js.xrpl.org/functions/convertStringToHex.html
https://js.xrpl.org/functions/convertHexToString.html
docs/tutorials/javascript/decentralized-finance/create-permissioned-domains.md
Outdated
Show resolved
Hide resolved
docs/tutorials/javascript/decentralized-finance/create-permissioned-domains.md
Outdated
Show resolved
Hide resolved
docs/tutorials/javascript/decentralized-finance/create-permissioned-domains.md
Outdated
Show resolved
Hide resolved
oeggert
force-pushed
the
permissioned-domains
branch
from
b01f4a5 to
d965bff
Compare
Topher68chris
previously approved these changes
May 28, 2025
oeggert
force-pushed
the
permissioned-domains
branch
from
d965bff to
cd53966
Compare
docs/tutorials/javascript/compliance/create-permissioned-domains.md
Outdated
Show resolved
Hide resolved
docs/tutorials/javascript/compliance/create-permissioned-domains.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
…ns.md Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
…ns.md Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
maria-robobug
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add modular tutorial for Permissioned Domains. Includes pending refactors from #3091