Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Jun 17, 2025

The package compiles a library, but does not expose any symbol on Windows, so if the CMake project is compiled on on Windows, no library is actually generated.

On Linux and macOS, everything compiles by default all the symbols are visible. We can achieve exactly the same behavior in Windows by setting to ON the CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS CMake variable, so this PR sets the CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS variable to ON, to ensure that the compilation works fine on Windows.

Furthermore, the -Wpedantic -Werror are GCC/Clang specific compilations options, so I moved it in an if for adding GCC/Clang specific compilations options.


This is an automatic backport of pull request #1402 done by Mergify.

(cherry picked from commit 04997b8)

# Conflicts:
#	ur_controllers/CMakeLists.txt
@mergify mergify bot added the conflicts label Jun 17, 2025
@mergify
Copy link
Author

mergify bot commented Jun 17, 2025

Cherry-pick of 04997b8 has failed:

On branch mergify/bp/humble/pr-1402
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 04997b8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ur_controllers/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@urfeex urfeex added humble Relevant for humble and higher ROS versions bugfix and removed conflicts labels Jun 17, 2025
@urfeex urfeex merged commit daba626 into humble Jun 17, 2025
7 checks passed
@urfeex urfeex deleted the mergify/bp/humble/pr-1402 branch June 17, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix humble Relevant for humble and higher ROS versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants