Skip to content

Conversation

@fmauch
Copy link
Contributor

@fmauch fmauch commented Oct 28, 2024

As usual, please rebase-merge, I'll push the tags and bloom-release later.

@fmauch fmauch requested a review from VinDp October 28, 2024 16:01
Copy link
Contributor

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the suggested lines: usually it's either "backport of" or directly the backported PR linked, while in this case both are there. Not important, just seems redundant.

2.3.11 (2024-10-28)
-------------------
* Allow setting the analog output domain when setting an analog output (backport of `#1123 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/1123>`_)
* Service to get software version of robot (`#964 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/964>`_) (`#1128 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/1128>`_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Service to get software version of robot (`#964 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/964>`_) (`#1128 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/1128>`_)
* Service to get software version of robot (`#1128 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/1128>`_)

-------------------
* Allow setting the analog output domain when setting an analog output (backport of `#1123 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/1123>`_)
* Fix component lifecycle (backport of `#1098 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/1098>`_)
* Service to get software version of robot (`#964 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/964>`_) (`#1128 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/1128>`_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Service to get software version of robot (`#964 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/964>`_) (`#1128 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/1128>`_)
* Service to get software version of robot (`#1128 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/1128>`_)

@fmauch fmauch merged commit 77ce8fb into UniversalRobots:iron Oct 29, 2024
7 checks passed
@fmauch fmauch deleted the release/2.3.11 branch October 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants