Skip to content

fix(ngc): dont double every message, if we are not directly connected #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

fix(ngc): dont double every message, if we are not directly connected

219773b
Select commit
Loading
Failed to load commit list.
Merged

fix(ngc): dont double every message, if we are not directly connected #2905

fix(ngc): dont double every message, if we are not directly connected
219773b
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded May 13, 2025 in 1s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : fix(ngc): dont double every message, if we are not directly connected
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : fix(ngc): dont double every message, if we are not directly connected
    but we and the other peer would support direct.
    Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : but we and the other peer would support direct.

Recreation of #2894 , since the ci is acting funny there.


All hail the network profiler.

image
(missing returning udp traffic)


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}