fix(ngc): dont double every message, if we are not directly connected #2905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but we and the other peer would support direct.
github-actions
bot
added
the
bug
nurupo
approved these changes
May 13, 2025
There was a problem hiding this comment.
LGTM.
In case someone stumbles upon this without reading the earlier PR - as pointed out in the earlier PR #2894 (comment), this is a dirty workaround rather than a proper fix.
JFreegman
approved these changes
May 13, 2025
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but we and the other peer would support direct.
Recreation of #2894 , since the ci is acting funny there.
All hail the network profiler.
(missing returning udp traffic)
This change is