[ZH] Fix multiplayer mismatch on starting a new game after exiting the previous game when power sabotaged #1238
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caball009
reviewed
Jul 7, 2025
Mauller
force-pushed
the
fix-power-sabotage-mismatch
branch
from
e76ee47 to
807285e
Compare
|
Tweaked |
Mauller
added
Major
|
This only applies to Zero Hour as the saboteur only exists there. I don't always remember which units were added in Zero Hour so I figured I mention it here in case anyone else was wondering whether this needs to be applied to Generals as well. |
Caball009
approved these changes
Jul 7, 2025
xezon
changed the title
xezon
approved these changes
Jul 7, 2025
I get it, i was trying to not go over the top with the title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents a mismatch from occuring in a new game when a previous game had the players power sabotaged.
Since the
m_powerSabotagedTillFramevariable was not being reset, the game would think the players power was still sabotaged when starting a new game.This is due to the
m_powerSabotagedTillFramevalue being greater than the current frame number, this then makes the game think the power is sabotaged.