Conversion and test of an empty Component Definition #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pySBOL2 can make objects without namespaces Shouldn't assume they will have a namespaces list
Made a function to handle identities Changed how that is handled back and forth for Component Definitions
Added test and test file for ComponentDefinition. I don't know why this wasn't commited earlier
Need to strip the version from persistent identity after creating the object
Restored test with new minimal file for collection
After completing converter code, there is still some things you need to do
Adapted existing implementation file since we don't have a SBOL Notebooks version
jakebeal
requested changes
Apr 17, 2025
Also fixed description for implementation test
Added empty Component Definition file and enabled the test for it
PrashantVaidyanathan
approved these changes
Apr 22, 2025
jakebeal
requested changes
Apr 24, 2025
Files were generated by running the converter on this commit (all tests were passing)
jakebeal
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from discussions on Harmony 2025 and issue #283, I made some changes to handle URIs in SBOL compliant files.
Main points:
This PR also handles a minor error that showed up when converting objects with
namespace=None. I just check if there is a namespace list before going through it.The conversion of Collection and Implementation is now outdated and untested, which will be recovered in a later PR.