You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would say that it's important to keep these objects around as is: they are legal non-compliant SBOL2.
However, I think it would be OK to also add compliant variants of these objects, and to clearly mark which are and are not compliant and why in their comments / descriptions.
I'm going to reopen this, since per @fxbuson 's comment on PR #315, these files will not yet be handled without errors.
To close this issue, update the converter so that these files are able to round-trip from SBOL2 to SBOL3 to SBOL2 without error and while still preserving their original (non-compliant) URI.
According to the SBOL 2.3 specification, section 12.3: "Compliant SBOL Objects", item 6:
Right now, test files such as BBa_J23101.xml have a version, but don't have the "/〈version〉" on their identity:
If I create a file with pysbol2 with
SBOL_COMPLIANT_URIS
asTrue
, the identity will have the "/〈version〉".Similarly, exports from SynbioHub right now also include the version in the identity:
I propose we change these test files to versions with the compliant format, adding their versions to the end of their Identities.
This is important because we are generating new test files for the new converter with pysbol2, and we need to be able to test the changes we make.
The text was updated successfully, but these errors were encountered: